From: "Lukáš Czerner" <lczerner@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
xfs@oss.sgi.com
Subject: Re: [PATCH v2 6/8] fsstress: translate flags in fiemap_f
Date: Thu, 6 Mar 2014 19:02:16 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.00.1403061900300.2249@localhost.localdomain> (raw)
In-Reply-To: <20140306174813.GE28297@infradead.org>
On Thu, 6 Mar 2014, Christoph Hellwig wrote:
> Date: Thu, 6 Mar 2014 09:48:13 -0800
> From: Christoph Hellwig <hch@infradead.org>
> To: Lukas Czerner <lczerner@redhat.com>
> Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com
> Subject: Re: [PATCH v2 6/8] fsstress: translate flags in fiemap_f
>
> > +#ifdef HAVE_LINUX_FIEMAP_H
> > +struct print_flags fiemap_flags[] = {
> > + { FIEMAP_FLAG_SYNC, "SYNC"},
> > + { FIEMAP_FLAG_XATTR, "XATTR"},
> > + { -1, NULL}
> > +};
>
> Can be static.
Right. The same applies to falloc_flags
>
> > +
> > +#define translate_fiemap_flags(mode) \
> > + ({translate_flags(mode, "|", fiemap_flags);})
> > +#endif
>
> Any reason to not have these two inside fiemap_f?
Not really, other than I think it's ugly.
>
> Otherwise:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks!
-Lukas
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-03-06 18:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 15:51 [PATCH v2 0/8] Add tests for zero range into xfstests Lukas Czerner
2014-03-05 15:51 ` [PATCH v2 1/8] xfstests: Create single function for testing xfs_io commands Lukas Czerner
2014-03-06 17:44 ` Christoph Hellwig
2014-03-06 17:57 ` Lukáš Czerner
2014-03-05 15:51 ` [PATCH v2 2/8] xfstests: create _test_block_boundaries in common/punch Lukas Czerner
2014-03-06 17:45 ` Christoph Hellwig
2014-03-05 15:51 ` [PATCH v2 3/8] generic/008: Add test for fallocate zero range at block boundary Lukas Czerner
2014-03-06 17:46 ` Christoph Hellwig
2014-03-05 15:51 ` [PATCH v2 4/8] xfstests: Move fallocate include into global.h Lukas Czerner
2014-03-06 17:47 ` Christoph Hellwig
2014-03-05 15:51 ` [PATCH v2 5/8] xfstests: Add fallocate zero range operation to fsstress Lukas Czerner
2014-03-05 15:51 ` [PATCH v2 6/8] fsstress: translate flags in fiemap_f Lukas Czerner
2014-03-06 17:48 ` Christoph Hellwig
2014-03-06 18:02 ` Lukáš Czerner [this message]
2014-03-05 15:51 ` [PATCH v2 7/8] xfstests: Add fallocate zero range operation to fsx Lukas Czerner
2014-03-05 15:51 ` [PATCH v2 8/8] ext4/001: Add ext4 specific test for fallocate zero range Lukas Czerner
2014-03-13 3:22 ` [PATCH v2 0/8] Add tests for zero range into xfstests Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1403061900300.2249@localhost.localdomain \
--to=lczerner@redhat.com \
--cc=hch@infradead.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).