From: "Lukáš Czerner" <lczerner@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-ext4@vger.kernel.org
Subject: re: ext4: Introduce FALLOC_FL_ZERO_RANGE flag for fallocate
Date: Mon, 31 Mar 2014 10:41:58 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.00.1403311041410.4996@localhost.localdomain> (raw)
In-Reply-To: <20140328080356.GB25192@mwanda>
On Fri, 28 Mar 2014, Dan Carpenter wrote:
> Date: Fri, 28 Mar 2014 11:03:56 +0300
> From: Dan Carpenter <dan.carpenter@oracle.com>
> To: lczerner@redhat.com
> Cc: linux-ext4@vger.kernel.org
> Subject: re: ext4: Introduce FALLOC_FL_ZERO_RANGE flag for fallocate
>
> Hello Lukas Czerner,
>
> The patch 1f0e51771281: "ext4: Introduce FALLOC_FL_ZERO_RANGE flag
> for fallocate" from Mar 18, 2014, leads to the following static
> checker warning:
>
> fs/ext4/extents.c:3653 ext4_split_convert_extents()
> warn: odd binop '0x4 & 0x10'
>
> fs/ext4/extents.c
> 3650 } else if (flags | EXT4_GET_BLOCKS_CONVERT) {
> 3651 split_flag |= ee_block + ee_len <= eof_block ?
> 3652 EXT4_EXT_MAY_ZEROOUT : 0;
> 3653 split_flag |= (EXT4_EXT_MARK_UNINIT2 & EXT4_EXT_DATA_VALID2);
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Right,
thanks.
-Lukas
> This statement is a no-op. Probably | was intended?
>
> 3654 }
> 3655 flags |= EXT4_GET_BLOCKS_PRE_IO;
>
> regards,
> dan carpenter
>
prev parent reply other threads:[~2014-03-31 8:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 8:03 ext4: Introduce FALLOC_FL_ZERO_RANGE flag for fallocate Dan Carpenter
2014-03-31 8:41 ` Lukáš Czerner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1403311041410.4996@localhost.localdomain \
--to=lczerner@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).