Re: [PATCH 7/7] mke2fs: only print the low-level file system stats in verbose mode

["Lukáš Czerner" <lczerner@redhat.com>]

On Sat, 26 Apr 2014, Theodore Ts'o wrote:

> Date: Sat, 26 Apr 2014 20:00:34 -0400
> From: Theodore Ts'o <tytso@mit.edu>
> To: Ext4 Developers List <linux-ext4@vger.kernel.org>
> Cc: Theodore Ts'o <tytso@mit.edu>
> Subject: [PATCH 7/7] mke2fs: only print the low-level file system stats in
>     verbose mode

While I kind of like this, because mke2fs is really quite verbose as
it is. However I am afraid that this will break scripts for people.

Also there are actually some useful information in that output like
block size, size of the file system and file system label if
specified. Also maybe having UUID in there will be also useful.

Thanks!
-Lukas

> 
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
> ---
>  misc/mke2fs.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/misc/mke2fs.c b/misc/mke2fs.c
> index 3694ce5..b274165 100644
> --- a/misc/mke2fs.c
> +++ b/misc/mke2fs.c
> @@ -618,6 +618,9 @@ static void show_stats(ext2_filsys fs)
>  	dgrp_t			i;
>  	int			need, col_left;
>  
> +	if (!verbose)
> +		goto skip_details;
> +
>  	if (ext2fs_blocks_count(&fs_param) != ext2fs_blocks_count(s))
>  		fprintf(stderr, _("warning: %llu blocks unused.\n\n"),
>  		       ext2fs_blocks_count(&fs_param) - ext2fs_blocks_count(s));
> @@ -666,6 +669,7 @@ static void show_stats(ext2_filsys fs)
>  		       s->s_blocks_per_group, s->s_clusters_per_group);
>  	printf(_("%u inodes per group\n"), s->s_inodes_per_group);
>  
> +skip_details:
>  	if (fs->group_desc_count == 1) {
>  		printf("\n");
>  		return;
>