From: "Lukáš Czerner" <lczerner@redhat.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 7/7] mke2fs: only print the low-level file system stats in verbose mode
Date: Wed, 30 Apr 2014 16:25:35 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.00.1404301616380.2100@localhost.localdomain> (raw)
In-Reply-To: <20140430140150.GA9213@thunk.org>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 2007 bytes --]
On Wed, 30 Apr 2014, Theodore Ts'o wrote:
> Date: Wed, 30 Apr 2014 10:01:50 -0400
> From: Theodore Ts'o <tytso@mit.edu>
> To: Lukáš Czerner <lczerner@redhat.com>
> Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
> Subject: Re: [PATCH 7/7] mke2fs: only print the low-level file system stats in
> verbose mode
>
> On Wed, Apr 30, 2014 at 01:22:52PM +0200, Lukáš Czerner wrote:
> > On Sat, 26 Apr 2014, Theodore Ts'o wrote:
> >
> > > Date: Sat, 26 Apr 2014 20:00:34 -0400
> > > From: Theodore Ts'o <tytso@mit.edu>
> > > To: Ext4 Developers List <linux-ext4@vger.kernel.org>
> > > Cc: Theodore Ts'o <tytso@mit.edu>
> > > Subject: [PATCH 7/7] mke2fs: only print the low-level file system stats in
> > > verbose mode
> >
> > While I kind of like this, because mke2fs is really quite verbose as
> > it is. However I am afraid that this will break scripts for people.
>
> Are there scripts that are really trying to parse the output of
> mke2fs? The output hasn't really been _that_ stable. I'm sure we've
> added stuff in the past, althoughg admittedly the this is the first
> time that we would be removing stuff.
Yes, that's what I worry about. Addition would most likely not break
grep, but removal will surely do. I am sure that there are admins
doing that.
It also does not help that other file systems are printing out
various "low level" information.
Despite the fact that parsing mkfs output is not the best thing to
do I am on the fence whether we want to break it or not.
>
> > Also there are actually some useful information in that output like
> > block size, size of the file system and file system label if
> > specified. Also maybe having UUID in there will be also useful.
>
> The block sizs is pretty much always 4k, and the file system label is
> only there if the user specified one on the command line. I can see
> how the size and UUID might be useful, though.
>
> How about if we just print the size and UUID?
Sounds good to me.
-Lukas
>
> - Ted
>
next prev parent reply other threads:[~2014-04-30 14:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-27 0:00 [PATCH 1/7] mke2fs: don't ask the proceed question using a regular file Theodore Ts'o
2014-04-27 0:00 ` [PATCH 2/7] mke2fs, tune2fs: call proceed_question() from check_plausibility()'s caller Theodore Ts'o
2014-04-27 0:00 ` [PATCH 3/7] mke2fs: don't complain if the regular file is too small Theodore Ts'o
2014-04-28 15:26 ` Eric Sandeen
2014-04-27 0:00 ` [PATCH 4/7] mke2fs: create a regular file if necessary Theodore Ts'o
2014-04-30 12:21 ` Lukáš Czerner
2014-04-30 14:06 ` Theodore Ts'o
2014-04-30 14:14 ` Lukáš Czerner
2014-04-30 14:18 ` Theodore Ts'o
2014-04-30 14:35 ` Lukáš Czerner
2014-04-30 15:26 ` Theodore Ts'o
2014-05-05 15:17 ` Eric Sandeen
2014-04-27 0:00 ` [PATCH 5/7] mke2fs: proceed if the user doesn't type anything after 5 seconds Theodore Ts'o
2014-04-28 15:33 ` Eric Sandeen
2014-04-28 15:36 ` Eric Sandeen
2014-04-28 23:26 ` Theodore Ts'o
2014-04-29 0:32 ` Eric Sandeen
2014-04-30 6:53 ` Lukáš Czerner
2014-04-27 0:00 ` [PATCH 6/7] mke2fs: check for pre-existing file system Theodore Ts'o
2014-04-30 11:50 ` Lukáš Czerner
2014-04-30 13:44 ` Lukáš Czerner
2014-04-30 14:10 ` Theodore Ts'o
2014-04-27 0:00 ` [PATCH 7/7] mke2fs: only print the low-level file system stats in verbose mode Theodore Ts'o
2014-04-30 11:22 ` Lukáš Czerner
2014-04-30 14:01 ` Theodore Ts'o
2014-04-30 14:25 ` Lukáš Czerner [this message]
2014-04-28 15:24 ` [PATCH 1/7] mke2fs: don't ask the proceed question using a regular file Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1404301616380.2100@localhost.localdomain \
--to=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).