From: "Lukáš Czerner" <lczerner@redhat.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH 4/7] mke2fs: create a regular file if necessary
Date: Wed, 30 Apr 2014 16:35:12 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.00.1404301628010.2100@localhost.localdomain> (raw)
In-Reply-To: <20140430141815.GE9213@thunk.org>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1708 bytes --]
On Wed, 30 Apr 2014, Theodore Ts'o wrote:
> Date: Wed, 30 Apr 2014 10:18:15 -0400
> From: Theodore Ts'o <tytso@mit.edu>
> To: Lukáš Czerner <lczerner@redhat.com>
> Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
> Subject: Re: [PATCH 4/7] mke2fs: create a regular file if necessary
>
> On Wed, Apr 30, 2014 at 04:14:16PM +0200, Lukáš Czerner wrote:
> > > Hmm, it occurs to me if the user typo's the file name in and the user
> > > specifies the size explicitly (i.e., "mke2fs /dev/scd3 2T) , it could
> > > result in the the root file system filling up. I'm not sure that's
> > > big of a deal, since the user can always control-C the mke2fs and then
> > > delete the typo'ed file name. Do we think this is a real problem?
> > > I'm not too worried...
> >
> > Oops, yes that would be nasty :) I'm not too worried either, but
> > I've done my share of typos as well, so I am not sure. And since
> > we're already asking a lot of questions anyway maybe we can ask
> > about this one as well ?
>
> The problem is if we do this, then scripts will do "mke2fs -F ..." to
> avoid the query, and I'd really like to avoid training script authors
> to do this. It undoes the point of some of the other patches in this
> patch series.
Yes, I do not like having to force people to use force either. Well,
there is a certain limit where we should go to correct user
mistakes and it seems that beyond that...
But having mkfs to print out the information that it's actually
creating the file is the least we can do.
-Lukas
>
> We could have some proceed_questions() fail to "yes", and some fail to
> "no", but I'm wondering if we really want to go to that level of
> complexity....
>
> - Ted
>
next prev parent reply other threads:[~2014-04-30 14:35 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-27 0:00 [PATCH 1/7] mke2fs: don't ask the proceed question using a regular file Theodore Ts'o
2014-04-27 0:00 ` [PATCH 2/7] mke2fs, tune2fs: call proceed_question() from check_plausibility()'s caller Theodore Ts'o
2014-04-27 0:00 ` [PATCH 3/7] mke2fs: don't complain if the regular file is too small Theodore Ts'o
2014-04-28 15:26 ` Eric Sandeen
2014-04-27 0:00 ` [PATCH 4/7] mke2fs: create a regular file if necessary Theodore Ts'o
2014-04-30 12:21 ` Lukáš Czerner
2014-04-30 14:06 ` Theodore Ts'o
2014-04-30 14:14 ` Lukáš Czerner
2014-04-30 14:18 ` Theodore Ts'o
2014-04-30 14:35 ` Lukáš Czerner [this message]
2014-04-30 15:26 ` Theodore Ts'o
2014-05-05 15:17 ` Eric Sandeen
2014-04-27 0:00 ` [PATCH 5/7] mke2fs: proceed if the user doesn't type anything after 5 seconds Theodore Ts'o
2014-04-28 15:33 ` Eric Sandeen
2014-04-28 15:36 ` Eric Sandeen
2014-04-28 23:26 ` Theodore Ts'o
2014-04-29 0:32 ` Eric Sandeen
2014-04-30 6:53 ` Lukáš Czerner
2014-04-27 0:00 ` [PATCH 6/7] mke2fs: check for pre-existing file system Theodore Ts'o
2014-04-30 11:50 ` Lukáš Czerner
2014-04-30 13:44 ` Lukáš Czerner
2014-04-30 14:10 ` Theodore Ts'o
2014-04-27 0:00 ` [PATCH 7/7] mke2fs: only print the low-level file system stats in verbose mode Theodore Ts'o
2014-04-30 11:22 ` Lukáš Czerner
2014-04-30 14:01 ` Theodore Ts'o
2014-04-30 14:25 ` Lukáš Czerner
2014-04-28 15:24 ` [PATCH 1/7] mke2fs: don't ask the proceed question using a regular file Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1404301628010.2100@localhost.localdomain \
--to=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).