Re: [PATCH 3/3] mke2fs: check for a partition table and warn if present

Theodore Ts'o
2014-05-05T14:20:59Z

On Mon, May 05, 2014 at 04:11:41PM +0200, Lukáš Czerner wrote:
>
> Fair enough. But we should still make the use of system libblkid by
> default if you do not have any objections.

What I want to do is test to see if there is a system libblkid
available at all, and if so, use it by default. I want to be able to
use the internal libblkid for development testing purposes, but the
goal is that when Andreas builds on MacOS, it should use the internal
libblkid by default (since there is no system blkid), but on Linux
systems, we should use the system blkid by default in the 1.43 branch.

> Also it'll be great to mention that in the commit description that
> this is the reason why we still try to use the old approach.

Fair enough. Actually, we should probably put it in the code
comments.

> blkid_probe_enable_superblocks(pr, 0);

Ok, thanks.

- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html