Re: [PATCH 1/3] mke2fs: print a message when creating a regular file

Theodore Ts'o
2014-05-05T13:52:41Z

On Mon, May 05, 2014 at 03:41:01PM +0200, Lukáš Czerner wrote:
> On Mon, 5 May 2014, Theodore Ts'o wrote:
>
> > Date: Mon, 5 May 2014 09:04:02 -0400
> > From: Theodore Ts'o <tytso@mit.edu>
> > To: Ext4 Developers List <linux-ext4@vger.kernel.org>
> > Cc: Theodore Ts'o <tytso@mit.edu>
> > Subject: [PATCH 1/3] mke2fs: print a message when creating a regular file
>
> Description is missing.

I didn't think more of a description was needed; can you suggest one?

> > /* Can't undo discard ... */
> > - if (!noaction && discard && (io_ptr != undo_io_manager)) {
> > + if (!noaction && discard && dev_size && (io_ptr != undo_io_manager)) {
>
> I wonder whether it's possible not to have dev_size set at this point ?

I checked, and I don't believe so. ext2fs_get_device_size2() never
returns EXT2_ET_UNIMPLEMENTED any more; and it hasn't for quite some
time, since it will use st_size for a regular file or do a binary
search trying to figure out the device size in the worst case. So in
fact, there are some code paths we can eliminate in misc/mke2fs.c
which will simplify this analysis.

Even if there is some case in the future where dev_size could be left
unset, it will be initialized to zero, at which point we will fail
safe by skipping the mke2fs_discard_device() call.

>
> > + if ((fd < 0) && (errno == ENOENT) && (flags & CREATE_FILE)) {
> > + fl |= O_CREAT;
> > + fd = open(device, fl, 0666);
> > + if (fd >= 0 && (flags & VERBOSE_CREATE))
>
> Do we have to use VERBOSE_CREATE ? quiet is global variable so we
> can as well just test that here, or am I missing something ?

The problem is that util.c gets used by both mke2fs.c and tune2fs.c,
and it's only a global variable for mke2fs.c.

My long-term plans is to rename libquota to libsupport, which would
never be built as a shared library, and move some of our various
internal shared utility functions (i.e., e2fsck/profile.c,
misc/util.c, etc.) into that internal e2fsprogs insternal support
library. So in general I'd prefer to minimize the number of global
functions which misc/util.c relies upon.

Cheers,

- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html