Re: [PATCH 2/3] mke2fs: print extra information about existing ext2/3/4 file systems

Lukáš Czerner
2014-05-05T14:17:15Z

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1698 bytes --]

On Mon, 5 May 2014, Theodore Ts'o wrote:

> Date: Mon, 5 May 2014 10:04:01 -0400
> From: Theodore Ts'o <tytso@mit.edu>
> To: Lukáš Czerner <lczerner@redhat.com>
> Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
> Subject: Re: [PATCH 2/3] mke2fs: print extra information about existing
> ext2/3/4 file systems
>
> On Mon, May 05, 2014 at 03:45:17PM +0200, Lukáš Czerner wrote:
> >
> > Now I am actually confused, sorry. Which patches do I need to get this
> > context? I do not see this in the next branch.
>
> These are based on the mke2fs patches I had sent earlier. Sorry, I
> haven't updated the maint branch in a while.
>
> The basic idea behinid these patches is that we now get a bit more
> context with the warning message for ext2/3/4 file systems:
>
> % ./misc/mke2fs -t ext4 /dev/heap/media
> mke2fs 1.42.9 (4-Feb-2014)
> /dev/heap/media contains a ext4 file system labelled 'media'
> last mounted on /media on Mon May 5 08:59:53 2014
> Proceed anyway? (y,n)
>
> I have modified those earlier patches in response to your earlier
> feedback; we no longer use the 5 second delay by default --- but we
> skip doing the check at all if either stdin or stdout is not a tty.
> This saves us in the situation where there is some script which does
> somethign like this:
>
> mke2fs -t ext4 /dev/sdc3 > /tmp/mke2fs.out
>
> Basically, we will only ask the user for confirmation when we are
> certain a user can see both the question and be able to type a
> response. It's possible we could still get confused by someone
> running mke2fs under a chat/expect script, but that seems like an
> acceptable risk.

Ok, that makes sense, thanks.

-Lukas

>
>
> - Ted
>