From: "Lukáš Czerner" <lczerner@redhat.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH -v2] ext4: rearrange initialization to fix EXT4FS_DEBUG
Date: Mon, 14 Jul 2014 14:09:51 +0200 (CEST) [thread overview]
Message-ID: <alpine.LFD.2.00.1407141409210.13527@localhost.localdomain> (raw)
In-Reply-To: <20140714115623.GC8935@thunk.org>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 864 bytes --]
On Mon, 14 Jul 2014, Theodore Ts'o wrote:
> Date: Mon, 14 Jul 2014 07:56:23 -0400
> From: Theodore Ts'o <tytso@mit.edu>
> To: Lukáš Czerner <lczerner@redhat.com>
> Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
> Subject: Re: [PATCH -v2] ext4: rearrange initialization to fix EXT4FS_DEBUG
>
> On Mon, Jul 14, 2014 at 10:04:47AM +0200, Lukáš Czerner wrote:
> > > + block = ext4_count_free_clusters(sb);
> > > + ext4_free_blocks_count_set(sbi->s_es, block);
> >
> >
> > This does not seem right. block is in cluster units so we need to
> > convert.
> >
> > ext4_free_blocks_count_set(sbi->s_es, EXT4_C2B(sbi, blocks));
> >
> > Otherwise it looks good to me.
>
> Thanks, for catching this! II've fixed up the patch on the ext4 git tree.
>
> - Ted
In that case, you can add.
Reviewed-by: Lukas Czerner <lczerner@redhat.com>
Thanks!
-Lukas
prev parent reply other threads:[~2014-07-14 12:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-12 16:10 [PATCH -v2] ext4: rearrange initialization to fix EXT4FS_DEBUG Theodore Ts'o
2014-07-14 8:04 ` Lukáš Czerner
2014-07-14 11:56 ` Theodore Ts'o
2014-07-14 12:09 ` Lukáš Czerner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.1407141409210.13527@localhost.localdomain \
--to=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox