From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-15?Q?Luk=E1=A8_Czerner?= Subject: Re: [PATCH 1/1] jbd2: fix incorrect unlock on j_list_lock Date: Thu, 19 Mar 2015 10:48:45 +0100 (CET) Message-ID: References: <1426644518-29680-1-git-send-email-tsgatesv@gmail.com> <20150318173931.GJ29195@taesoo.org> Mime-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="8323328-689013918-1426758533=:29774" Cc: Taesoo Kim , tytso@mit.edu, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, changwoo@gatech.edu, sanidhya@gatech.edu, blee@gatech.edu, csong84@gatech.edu To: Taesoo Kim Return-path: In-Reply-To: <20150318173931.GJ29195@taesoo.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323328-689013918-1426758533=:29774 Content-Type: TEXT/PLAIN; charset=ISO-8859-15 Content-Transfer-Encoding: 8BIT On Wed, 18 Mar 2015, Taesoo Kim wrote: > Date: Wed, 18 Mar 2015 13:39:31 -0400 > From: Taesoo Kim > To: LukᨠCzerner > Cc: Taesoo Kim , tytso@mit.edu, > linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, > changwoo@gatech.edu, sanidhya@gatech.edu, blee@gatech.edu, > csong84@gatech.edu > Subject: Re: [PATCH 1/1] jbd2: fix incorrect unlock on j_list_lock > > > The patch looks good, thanks. > > Thank you. > > > Reviewed-by: Lukas Czerner > > > > Btw, were you able to reproduce the problem, or have you seen the > > problem in the wild ? Or did you just spot it in the code ? > > We are developing a static checker to spot inconsistent programming > patterns; our first goal is to scan over existing filesystems and > figure out how they are implemented differently (or similarly). We > will report bugs in sequence as soon as our team confirm (just start > sending patches to other fs). And this was found but it ? But anyway it sounds really interesting, do you have any more information you can share about the project ? Project website, description, or source code would be great :) Thanks! -Lukas > > Thanks, > Taesoo > > > Thanks! > > -Lukas > > > > > > > > Signed-off-by: Taesoo Kim > > > --- > > > fs/jbd2/transaction.c | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > diff --git a/fs/jbd2/transaction.c b/fs/jbd2/transaction.c > > > index 5f09370..edb7f59 100644 > > > --- a/fs/jbd2/transaction.c > > > +++ b/fs/jbd2/transaction.c > > > @@ -1091,6 +1091,7 @@ int jbd2_journal_get_create_access(handle_t *handle, struct buffer_head *bh) > > > JBUFFER_TRACE(jh, "file as BJ_Reserved"); > > > spin_lock(&journal->j_list_lock); > > > __jbd2_journal_file_buffer(jh, transaction, BJ_Reserved); > > > + spin_unlock(&journal->j_list_lock); > > > } else if (jh->b_transaction == journal->j_committing_transaction) { > > > /* first access by this transaction */ > > > jh->b_modified = 0; > > > @@ -1098,8 +1099,8 @@ int jbd2_journal_get_create_access(handle_t *handle, struct buffer_head *bh) > > > JBUFFER_TRACE(jh, "set next transaction"); > > > spin_lock(&journal->j_list_lock); > > > jh->b_next_transaction = transaction; > > > + spin_unlock(&journal->j_list_lock); > > > } > > > - spin_unlock(&journal->j_list_lock); > > > jbd_unlock_bh_state(bh); > > > > > > /* > > > -- > > > 2.3.3 > > > > > > -- > > > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > > > the body of a message to majordomo@vger.kernel.org > > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > --8323328-689013918-1426758533=:29774--