public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Ott <sebott@linux.vnet.ibm.com>
To: Theodore Tso <tytso@mit.edu>
Cc: "linux-ext4@vger.kernel.org development"
	<linux-ext4@vger.kernel.org>,
	LKML Kernel <linux-kernel@vger.kernel.org>,
	pm list <linux-pm@lists.linux-foundation.org>
Subject: Re: Oops while going into hibernate
Date: Thu, 13 Jan 2011 12:48:40 +0100 (CET)	[thread overview]
Message-ID: <alpine.LFD.2.02.1101131238480.1899@localhost6.localdomain6> (raw)
In-Reply-To: <A01161D0-D08F-4522-A546-90057B2E1F2A@mit.edu>


On Wed, 12 Jan 2011, Theodore Tso wrote:
> That looks really bogus.  /usr/bin/killall is a system binary, and there's
> no good reason that hibernation should be trying to write pages to that
> binary.
> 
> You said originally that the oops was happening "while going into
> hibernation right after resuming with...".   So that means you did a
> successful suspend/resume, and then the second suspend caused the oops?
Yes. I basically did a
echo reboot > /sys/power/disk
for i in {1..5} ;do echo disk > /sys/power/state ;done
and it crashed very early in the second suspend.

> It looks like somehow the pages were left marked as dirty, so the
> writeback daemons attempted writing back a page to an inode which was
> never opened read/write (and in fact as a text page for
> /usr/bin/killall, was mapped read/only).
> Given that ext4 initializes jinode only when the file is opened
> read/write, the fact that it is null, and the fact that it makes no
> sense that a program would be modifying /usr/bin/killall as part of a
> suspend/resume, it looks very much like we just unmasked a software
> suspend bug....
Ah, ok. Thanks for the explanation!

Regards,
Sebastian

  parent reply	other threads:[~2011-01-13 11:48 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-12 13:48 Oops while going into hibernate Sebastian Ott
2011-01-12 16:26 ` Ted Ts'o
2011-01-12 16:56   ` Sebastian Ott
2011-01-12 17:26     ` Ted Ts'o
2011-01-12 17:37       ` Sebastian Ott
2011-01-12 18:49       ` Sebastian Ott
2011-01-13  0:44         ` Theodore Tso
2011-01-13  5:56           ` Ted Ts'o
2011-01-13  5:59             ` [PATCH] PM / Hibernate: Don't mark pages dirty when reading pages while thawing Theodore Ts'o
2011-01-13 12:36               ` Sebastian Ott
2011-01-13 11:12           ` [linux-pm] Oops while going into hibernate Bojan Smojver
2011-01-13 11:49             ` Sebastian Ott
2011-01-13 11:48           ` Sebastian Ott [this message]
2011-01-13 12:11             ` Bojan Smojver
2011-01-13 12:31               ` Sebastian Ott
2011-01-13 13:36             ` Heiko Carstens
2011-01-13 18:46               ` Ted Ts'o
2011-01-13 21:30                 ` [linux-pm] " Bojan Smojver
2011-01-14  9:53                   ` Heiko Carstens
2011-01-14 13:14                     ` Bojan Smojver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.02.1101131238480.1899@localhost6.localdomain6 \
    --to=sebott@linux.vnet.ibm.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox