Linux EXT4 FS development
 help / color / mirror / Atom feed
From: Hugh Dickins <hughd@google.com>
To: Yongqiang Yang <xiaoqiangnk@gmail.com>
Cc: Allison Henderson <achender@linux.vnet.ibm.com>,
	Ted Ts'o <tytso@mit.edu>, Curt Wohlgemuth <curtw@google.com>,
	Surbhi Palande <csurbhi@gmail.com>, Rafael Wysocki <rjw@sisk.pl>,
	linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Bug with "fix partial page writes" [3.2-rc regression]
Date: Tue, 6 Dec 2011 14:31:37 -0800 (PST)	[thread overview]
Message-ID: <alpine.LSU.2.00.1112061412310.1949@sister.anvils> (raw)
In-Reply-To: <CAGBYx2YA3B5-nLxwdHavmd=794ycrpqnMbvM=VabrdPL2FQ0sw@mail.gmail.com>

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1497 bytes --]

On Tue, 6 Dec 2011, Yongqiang Yang wrote:
> On Tue, Dec 6, 2011 at 4:55 PM, Hugh Dickins <hughd@google.com> wrote:
> >
> > I've now tried the fsx test on three machines, with both 1/2 and 2/2
> > applied to 3.2-rc4.  On one machine, with ext2 on loop on tmpfs, the
> > fsx test failed in a couple of minutes with those patches; on another
> > machine, with ext2 on loop on tmpfs, it failed after about 40 minutes
> > with  the patches; on this laptop, with ext2 on SSD, it's just now
> > failed after 35 minutes with the patches.

> ext2?  So files are indirect mapped?  If so, the failure should has
> nothing to do with punching hole, I remember that punch hole is not
> supported for indirect mapped files.

Yes, I am not trying to test hole punching: just trying to do my own
testing under traditional loads, and hitting problems in changes which
have gone into extN to fix up hole punching.

Some of the time I've been using an old fsx which doesn't even know
about fallocate(), some of the time a recent fsx from xfstests.  Most
of the time I've been using ext2, but occasionally I try it on ext4.

I think the only thing which makes the problems go away is blocksize
same as pagesize; but it's a long time since I tried nomblk_io_submit,
that made a big difference around 2.6.38/39, perhaps it still does.

> 
> Do you mean fsx failure or the bug you reported earlier due to
> referencing a unlocked page?

In first quoted paragraph above, fsx failure.

Hugh

  reply	other threads:[~2011-12-06 22:32 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-08 22:59 Bug with "fix partial page writes" Curt Wohlgemuth
2011-11-20 20:59 ` Hugh Dickins
2011-11-21  1:59   ` Yongqiang Yang
2011-11-21 17:38     ` Allison Henderson
     [not found]       ` <CAMBkX3cfQ+XS7M5jvXmj8_rBOJ_Afy+YXL7Roj+fswLqBA7i1Q@mail.gmail.com>
2011-11-21 21:26         ` Fwd: " Surbhi Palande
2011-11-22 15:57           ` Allison Henderson
2011-11-22  1:44       ` Yongqiang Yang
2011-11-21 16:56   ` Ted Ts'o
2011-11-21 22:04     ` Hugh Dickins
2011-12-05 23:38       ` Bug with "fix partial page writes" [3.2-rc regression] Hugh Dickins
2011-12-06  1:40         ` Allison Henderson
2011-12-06  3:08           ` Yongqiang Yang
2011-12-06  3:20             ` Yongqiang Yang
2011-12-06  3:33             ` Tao Ma
2011-12-06  3:44               ` Yongqiang Yang
2011-12-06  4:05                 ` Allison Henderson
2011-12-06  7:57                   ` Yongqiang Yang
2011-12-06  8:55           ` Hugh Dickins
2011-12-06  9:32             ` Yongqiang Yang
2011-12-06 22:31               ` Hugh Dickins [this message]
2011-12-06 21:15             ` Allison Henderson
2011-12-06 22:47               ` Hugh Dickins
2011-12-07  8:28               ` Yongqiang Yang
2011-12-07 17:04                 ` Allison Henderson
2011-12-08  5:10                   ` Allison Henderson
2011-12-08 17:39                     ` Hugh Dickins
2011-12-08 18:12                       ` Andy Whitcroft
2011-12-09 13:33                         ` Andy Whitcroft
2011-12-09 13:44                           ` Yongqiang Yang
2011-12-09 16:37                             ` Allison Henderson
2011-12-14  4:12                       ` Ted Ts'o
2011-12-14 18:07                         ` Hugh Dickins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LSU.2.00.1112061412310.1949@sister.anvils \
    --to=hughd@google.com \
    --cc=achender@linux.vnet.ibm.com \
    --cc=csurbhi@gmail.com \
    --cc=curtw@google.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=tytso@mit.edu \
    --cc=xiaoqiangnk@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox