From: Roman Anufriev <dotdot@yandex-team.ru>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu, dmtrmonakhov@yandex-team.ru
Subject: Re: [PATCH v2 2/2] ext4: print quota journalling mode on (re-)mount
Date: Thu, 22 Oct 2020 06:29:18 +0300 (MSK) [thread overview]
Message-ID: <alpine.OSX.2.23.453.2010220623440.1375@dotdot-osx> (raw)
In-Reply-To: <20201019095259.GD30825@quack2.suse.cz>
On Mon, 19 Oct 2020, Jan Kara wrote:
> On Sun 18-10-20 05:02:27, Roman Anufriev wrote:
>> Right now, it is hard to understand what quota journalling type is enabled:
>> you need to be quite familiar with kernel code and trace it or really
>> understand what different combinations of fs flags/mount options lead to.
>>
>> This patch adds printing of current quota jounalling mode on each
>> mount/remount, thus making it easier to check it at a glance/in autotests.
>> The semantics is similar to ext4 data journalling modes:
>>
>> * journalled - quota accounting and journaling are enabled
>> * writeback - quota accounting is enabled, but journalling is disabled
>
> The above two descriptions are still somewhat misleading - in fact we don't
> know whether accounting is enabled or not. Just *if* it is enabled, quota
> will be journalled / non-journalled. So I'd probably describe it like:
> * journalled - quota configured, journalling will be enabled
> * writeback - quota configured, journalling will be disabled
Yeah, you are right, I'll fix this in v4.
> We've talked with Ted on last ext4 conf call and we agreed that it's
> probably time to deprecate old style quotas in external quota files and
> transition everybody to using quotas with quota feature. That way things
> will get simpler again. But before we can disable that functionality, it
> will take a few years of deprecation warnings etc. so that's not directly
> related to your patch here. JFYI.
It will be great!
Roman
next prev parent reply other threads:[~2020-10-22 3:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-18 2:02 [PATCH v2 1/2] ext4: add helpers for checking whether quota can be enabled/is journalled Roman Anufriev
2020-10-18 2:02 ` [PATCH v2 2/2] ext4: print quota journalling mode on (re-)mount Roman Anufriev
2020-10-18 3:22 ` kernel test robot
2020-10-19 9:46 ` Roman Anufriev
2020-10-19 9:52 ` Jan Kara
2020-10-22 3:29 ` Roman Anufriev [this message]
2020-10-19 9:37 ` [PATCH v2 1/2] ext4: add helpers for checking whether quota can be enabled/is journalled Jan Kara
2020-10-19 9:53 ` Jan Kara
2020-10-22 3:33 ` Roman Anufriev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.OSX.2.23.453.2010220623440.1375@dotdot-osx \
--to=dotdot@yandex-team.ru \
--cc=dmtrmonakhov@yandex-team.ru \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox