From: "Theodore Tso" <tytso@mit.edu>
To: Deepanshu Kartikey <kartikey406@gmail.com>
Cc: adilger.kernel@dilger.ca, libaokun@linux.alibaba.com,
jack@suse.cz, ojaswin@linux.ibm.com, ritesh.list@gmail.com,
yi.zhang@huawei.com, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org,
syzbot+293a57918b36cfae3d48@syzkaller.appspotmail.com
Subject: Re: [PATCH] ext4: defend against inline-to-block conversion race in write completion
Date: Thu, 23 Jul 2026 08:52:19 -0400 [thread overview]
Message-ID: <amIOFYmb6DlCxfMQ@mit.edu> (raw)
In-Reply-To: <20260718061238.50827-1-kartikey406@gmail.com>
On Sat, Jul 18, 2026 at 11:42:38AM -0500, Deepanshu Kartikey wrote:
> Replace BUG_ON(!ext4_has_inline_data(inode)) with defensive error handling
> in ext4_write_inline_data_end(). A file can be converted from inline to block
> storage by concurrent paths while a write completion is in flight.
Thanks for this proposed change. It's covered, as part of Aditya
Prakash Srivastava change, "ext4: use fsdata to track inline data
write state and fix race"[1] which is being tested in my tree.
[1] https://patch.msgid.link/20260703045414.1768-1-aditya.ansh182@gmail.com
- Ted
prev parent reply other threads:[~2026-07-23 12:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-18 6:12 [PATCH] ext4: defend against inline-to-block conversion race in write completion Deepanshu Kartikey
2026-07-23 12:52 ` Theodore Tso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=amIOFYmb6DlCxfMQ@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=kartikey406@gmail.com \
--cc=libaokun@linux.alibaba.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
--cc=syzbot+293a57918b36cfae3d48@syzkaller.appspotmail.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox