From: "Theodore Tso" <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Christian Brauner <brauner@kernel.org>,
linux-ext4@vger.kernel.org, Ojaswin Mujoo <ojaswin@linux.ibm.com>,
Venkat Rao Bagalkote <venkat88@linux.ibm.com>
Subject: Re: [PATCH] ext4: Avoid entering writeback paths during fastcommit replay
Date: Thu, 6 Aug 2026 10:48:47 -0400 [thread overview]
Message-ID: <anSeKuPHikw2UxRt@mit.edu> (raw)
In-Reply-To: <20260804104112.93202-2-jack@suse.cz>
On Tue, Aug 04, 2026 at 12:41:13PM -0500, Jan Kara wrote:
> Fastcommit replay effectively happens in nojournal mode. This results in
> ext4_mark_iloc_dirty() setting I_METADATA_WRITEBACK flag and as a result
> we end up entering filesystem writeback functions. However during
> fastcommit replay s_writepages_rwsem isn't initialized yet and hence we
> crash.
>
> Fix the problem by avoiding setting I_METADATA_WRITEBACK during
> fastcommit replay. Journal replay flushes the whole block device after
> replay anyway so all metadata is properly persisted and replay is faster
It looks like this patch is only applicable if the patch series "fs:
Fix missed inode write during fsync" is applied, and in fact appears
to fix a problem introduced in "[PATCH v5 17/20] ext4: Fix data
integrity writeout issues in nojournal mode"?
- Ted
next prev parent reply other threads:[~2026-08-06 14:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 10:41 [PATCH] ext4: Avoid entering writeback paths during fastcommit replay Jan Kara
2026-08-04 12:08 ` Ojaswin Mujoo
2026-08-06 14:48 ` Theodore Tso [this message]
2026-08-06 15:07 ` Jan Kara
2026-08-07 4:14 ` Venkat Rao Bagalkote
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=anSeKuPHikw2UxRt@mit.edu \
--to=tytso@mit.edu \
--cc=brauner@kernel.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=venkat88@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox