Re: [PATCH v8 02/13] fstests: add _clone_mount_option() helper

[Zorro Lang <zlang@kernel.org>]

On Sat, Jul 25, 2026 at 03:38:59PM +0800, Anand Jain wrote:
> Adds _clone_mount_option() helper function to handle filesystem-specific
> requirements for mounting cloned devices. Abstract the need for -o nouuid
> on XFS.
> 
> Signed-off-by: Anand Jain <asj@kernel.org>
> Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
> ---
>  common/rc | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/common/rc b/common/rc
> index e8ff5be0c547..53e5d9d43af6 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -414,6 +414,19 @@ _scratch_mount_options()
>  					$SCRATCH_DEV $SCRATCH_MNT
>  }
>  
> +# Return filesystem-specific mount options required for mounting clone/snapshot
> +# devices.
> +_clone_mount_option()

Just a minor nitpick :) For consistency with other *_mount_options functions
(in common/rc), I suggest using "options" instead of "option" -- _clone_mount_options

> +{
> +	case "$FSTYP" in
> +	xfs)
> +		# Allow mounting a duplicate filesystem on the same host
> +		echo "-o nouuid"
> +		;;
> +	*)
> +	esac
> +}
> +
>  _supports_filetype()
>  {
>  	local dir=$1
> -- 
> 2.43.0
>