Linux EXT4 FS development
 help / color / mirror / Atom feed
From: "Theodore Tso" <tytso@mit.edu>
To: Hengyu Liang <hengyul@cs.unc.edu>
Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: Possible regression: ext4 lsetxattr returns ENOSPC on malformed image since v7.3-rc1
Date: Wed, 2 Sep 2026 21:48:21 -0400	[thread overview]
Message-ID: <apjGcCYzNVZaH9Y7@mit.edu> (raw)
In-Reply-To: <20260902160352.A55AA600BB@cobra01.cs.unc.edu>

On Wed, Sep 02, 2026 at 12:03:52PM -0500, Hengyu Liang wrote:
>
> We found a stable ext4 behavior change: with the same malformed ext4 image,
> a large lsetxattr() succeeds through v7.2, but returns ENOSPC on v7.3-rc1.

What happens with a malformed ext4 image is quite frankly, not
interesting to me.  How we handle a maliciously corrupted image is not
something which is defined.  This is *especially* true given the use
of the mount option debug_want_extra_isize=104, which is not a
real-world use case, making this case doubly irrelevant.

(We've never actually used the code path which is designed to simulate
expanding the base inode in the two decades of ext4's existence.  This
is because it's rare that we want to sacrifice bytes for all inodes,
especially if the field is for a feature which might not be useful for
most users.  For most features that might only be used by a subset of
users, using an extended attribute, although it's less efficient, is
the preferred approach.)

Cheers,

							- Ted

      reply	other threads:[~2026-09-03  1:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-02 16:03 Possible regression: ext4 lsetxattr returns ENOSPC on malformed image since v7.3-rc1 Hengyu Liang
2026-09-03  1:48 ` Theodore Tso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=apjGcCYzNVZaH9Y7@mit.edu \
    --to=tytso@mit.edu \
    --cc=adilger.kernel@dilger.ca \
    --cc=hengyul@cs.unc.edu \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox