Linux EXT4 FS development
 help / color / mirror / Atom feed
From: "Theodore Tso" <tytso@mit.edu>
To: Julian Sun <sunjunchao@bytedance.com>
Cc: linux-ext4@vger.kernel.org, adilger.kernel@dilger.ca,
	libaokun@linux.alibaba.com, jack@suse.cz, ojaswin@linux.ibm.com,
	ritesh.list@gmail.com, yi.zhang@huawei.com,
	riteshh@linux.ibm.com
Subject: Re: [PATCH 0/6] ext4: fix buffered writeback error handling
Date: Thu, 22 Oct 2026 12:05:06 -0400	[thread overview]
Message-ID: <atoySP5ez1SwWh0X@mit.edu> (raw)
In-Reply-To: <20261022145241.2950379-1-sunjunchao@bytedance.com>

On Thu, Oct 22, 2026 at 10:52:35PM -0500, Julian Sun wrote:
> This series fixes error handling in ext4 buffered writeback. It prevents
> stale data exposure when mapping or io_end_vec allocation fails, reports
> unwritten conversion errors to fsync(), and preserves concurrent io_end
> flag updates.

Hi Julian,

Thanks for this series.  However, we have just landed a significant
change to the ext4 writeback to add support for fs/iomap's buffered
I/O.  It is currently not enabled by default, since there are a number
of features and mount options that aren't yet supported by the
buffered_iomap codepath.  (Thanks to Zhang Yi at Huawei for his work!)

I'd really appreciate it if you could rebase your patches on top of
the dev branch for the ext4 git tree (I've sent a pull request to
Linus so this should be in v7.4-rc1), and determine whether any of
these concerns are also applicable for the buffered_iomap codepath.

Many thanks,

						- Ted

  parent reply	other threads:[~2026-10-22 16:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-22 14:52 [PATCH 0/6] ext4: fix buffered writeback error handling Julian Sun
2026-10-22 14:52 ` [PATCH 1/6] ext4: move extent mapping error handling out of the loop Julian Sun
2026-10-22 15:15   ` sashiko-bot
2026-10-22 14:52 ` [PATCH 2/6] ext4: submit mapped buffers when io_end_vec allocation fails Julian Sun
2026-10-22 15:25   ` sashiko-bot
2026-10-22 14:52 ` [PATCH 3/6] ext4: prevent stale data exposure after fatal mapping errors Julian Sun
2026-10-22 15:40   ` sashiko-bot
2026-10-22 15:02 ` [PATCH 4/6] ext4: put folio on partial writeback validation failure Julian Sun
2026-10-22 15:15   ` sashiko-bot
2026-10-22 15:12 ` [PATCH 5/6] ext4: report unwritten extent conversion errors to fsync Julian Sun
2026-10-22 15:12   ` [PATCH 6/6] ext4: use atomic bitops for io_end flags Julian Sun
2026-10-22 15:17     ` sashiko-bot
2026-10-22 15:19   ` [PATCH 5/6] ext4: report unwritten extent conversion errors to fsync sashiko-bot
2026-10-22 16:05 ` Theodore Tso [this message]
2026-10-23  2:36   ` [PATCH 0/6] ext4: fix buffered writeback error handling Zhang Yi
2026-10-23  3:43     ` Ojaswin Mujoo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=atoySP5ez1SwWh0X@mit.edu \
    --to=tytso@mit.edu \
    --cc=adilger.kernel@dilger.ca \
    --cc=jack@suse.cz \
    --cc=libaokun@linux.alibaba.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=ojaswin@linux.ibm.com \
    --cc=ritesh.list@gmail.com \
    --cc=riteshh@linux.ibm.com \
    --cc=sunjunchao@bytedance.com \
    --cc=yi.zhang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox