Linux EXT4 FS development
 help / color / mirror / Atom feed
From: "Theodore Tso" <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Yichong Chen <chenyichong@uniontech.com>,
	adilger.kernel@dilger.ca, libaokun@linux.alibaba.com,
	ojaswin@linux.ibm.com, ritesh.list@gmail.com,
	yi.zhang@huawei.com, linux-ext4@vger.kernel.org,
	linux-kernel@vger.kernel.org, guanwentao@uniontech.com,
	niecheng1@uniontech.com, Morduan Zang <zhangdandan@uniontech.com>
Subject: Re: [PATCH] ext4: keep ordered data and i_disksize consistent on size changes
Date: Fri, 20 Nov 2026 11:17:55 -0500	[thread overview]
Message-ID: <awBwutTXygOERsY-@mit.edu> (raw)
In-Reply-To: <f5fv5eyvkpeqtopmigq5q7cd6265ptu3jn4xqwglhhsrcxorop@z3buh3cwimvn>

On Fri, Nov 20, 2026 at 01:02:24PM -0500, Jan Kara wrote:
> Yes, and as the LLM probably told you these checks are failing on ext4 for
> ages and no real user complained. Ted may have a different opinion but I
> don't think we care about fixing them, in particular given the costs in
> complexity of i_size updates and also performance of appending writes /
> truncate.

Yes.  In addition, there was never any data integrity guarantees of
data=ordered.  The main reason why this exists is to avoid any stale
data belonging a deleted file (which might be someone's PII, love
letters, offers to sell GPU's to export-restricted countries, etc.).
If the application wants data integrity guarantees, it should use
fsync(2).

The only reason why we have data=ordered is because we use the order
of operations from ext2 --- namely, first we allocate the block, then
we insert the block mapping into the inode, and then we write the data
to the newly allocated block.  Once we change things so that we write
the data block to the newly allocated block, and *then* we make the
metadata change, we can unify data=ordered and data=writeback; and
then once data=journal gets deprecated, all of the data=xxx mount
options will go away, and there will be only one way that we handle
writeback.

						- Ted

      reply	other threads:[~2026-11-20 16:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  7:50 [PATCH] ext4: keep ordered data and i_disksize consistent on size changes Yichong Chen
2026-11-18  8:43 ` sashiko-bot
2026-11-20 12:02 ` Jan Kara
2026-11-20 16:17   ` Theodore Tso [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=awBwutTXygOERsY-@mit.edu \
    --to=tytso@mit.edu \
    --cc=adilger.kernel@dilger.ca \
    --cc=chenyichong@uniontech.com \
    --cc=guanwentao@uniontech.com \
    --cc=jack@suse.cz \
    --cc=libaokun@linux.alibaba.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=niecheng1@uniontech.com \
    --cc=ojaswin@linux.ibm.com \
    --cc=ritesh.list@gmail.com \
    --cc=yi.zhang@huawei.com \
    --cc=zhangdandan@uniontech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox