From: Zhang Yi <yi.zhang@huaweicloud.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, tytso@mit.edu,
adilger.kernel@dilger.ca, jack@suse.cz, wanghaichi0403@gmail.com,
yi.zhang@huawei.com, libaokun1@huawei.com, yukuai3@huawei.com,
yangerkun@huawei.com
Subject: Re: [PATCH 4/4] ext4: ensure i_size is smaller than maxbytes
Date: Wed, 30 Apr 2025 11:32:04 +0800 [thread overview]
Message-ID: <bbe602bd-c421-4dd6-ad17-9cff39a3c097@huaweicloud.com> (raw)
In-Reply-To: <aBGW4TsUM5yOCf_8@casper.infradead.org>
On 2025/4/30 11:20, Matthew Wilcox wrote:
> On Wed, Apr 30, 2025 at 09:13:01AM +0800, Zhang Yi wrote:
>> From: Zhang Yi <yi.zhang@huawei.com>
>>
>> The inode i_size cannot be larger than maxbytes, check it while loading
>> inode from the disk.
>
> With this patch, why do we need patch 1?
The max_end in ext4_punch_hole() is maxbytes - blocksize. Therefore,
without the patch 1, it is still possible to encounter a negative
length if the offset exceeds max_end but is less than an i_size that
also exceeds max_end.
max_end i_size max_bytes
| | |
0------------------------------------
|
offset
Thanks,
Yi.
next prev parent reply other threads:[~2025-04-30 3:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-30 1:12 [PATCH 1/4] ext4: fix out of bounds punch offset Zhang Yi
2025-04-30 1:12 ` [PATCH 2/4] ext4: fix incorrect punch max_end Zhang Yi
2025-04-30 7:54 ` Jan Kara
2025-04-30 8:18 ` Jan Kara
2025-04-30 8:44 ` Zhang Yi
2025-04-30 10:09 ` Jan Kara
2025-04-30 10:54 ` Zhang Yi
2025-04-30 1:13 ` [PATCH 3/4] ext4: factor out ext4_get_maxbytes() Zhang Yi
2025-04-30 7:55 ` Jan Kara
2025-04-30 1:13 ` [PATCH 4/4] ext4: ensure i_size is smaller than maxbytes Zhang Yi
2025-04-30 3:20 ` Matthew Wilcox
2025-04-30 3:32 ` Zhang Yi [this message]
2025-04-30 8:01 ` Jan Kara
2025-04-30 7:51 ` [PATCH 1/4] ext4: fix out of bounds punch offset Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbe602bd-c421-4dd6-ad17-9cff39a3c097@huaweicloud.com \
--to=yi.zhang@huaweicloud.com \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=libaokun1@huawei.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=wanghaichi0403@gmail.com \
--cc=willy@infradead.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox