linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steven Liu <lingjiujianke@gmail.com>
To: tytso@mit.edu, linux-ext4@vger.kernel.org
Subject: [PATCH 1/1]ext4: cleanup a warning
Date: Tue, 16 Mar 2010 18:54:43 +0800	[thread overview]
Message-ID: <bd0d95d71003160354h538eec47t3246b397f4e0c5be@mail.gmail.com> (raw)

Hi Ted,

        I have get a warning, too,


fs/ext4/move_extent.c:478: warning: start_ext.ee_block may be used
uninitialized in this function

my compiler version:

gcc (GCC) 4.3.2 20081105 (Red Hat 4.3.2-7)
Copyright (C) 2008 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.


I think i'm not the first get this warning,then i make a patch for
this warning, can you fix it in?

Signed-off-by: Qi Liu (lingjiujianke@gmail.com)

diff --git a/ext4/fs/ext4/move_extent.c.orig b/ext4/fs/ext4/move_extent.c
index aa5fe28..b399358 100644
--- a/ext4/fs/ext4/move_extent.c.orig
+++ b/ext4/fs/ext4/move_extent.c
@@ -481,6 +481,7 @@ mext_leaf_block(handle_t *handle, struct inode *orig_inode,
        int depth = ext_depth(orig_inode);
        int ret;

+       start_ext.ee_block = end_ext.ee_block = 0;
        o_start = o_end = oext = orig_path[depth].p_ext;
        oext_alen = ext4_ext_get_actual_len(oext);
        start_ext.ee_len = end_ext.ee_len = 0;




                                Qi Liu

                 reply	other threads:[~2010-03-16 10:54 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bd0d95d71003160354h538eec47t3246b397f4e0c5be@mail.gmail.com \
    --to=lingjiujianke@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).