public inbox for linux-ext4@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonny Grant <jg@jguk.org>
To: linux-ext4@vger.kernel.org
Subject: /fs/ext4/ext4.h add a comment to ext4_dir_entry_2
Date: Sun, 3 May 2020 13:52:24 +0100	[thread overview]
Message-ID: <bf50e54f-2a0c-17a4-89c3-4afcc298daeb@jguk.org> (raw)

Hello

Could a comment be added to clarify 'file_type' ?

struct ext4_dir_entry_2 {
     __le32    inode;            /* Inode number */
     __le16    rec_len;        /* Directory entry length */
     __u8    name_len;        /* Name length */
     __u8    file_type;
     char    name[EXT4_NAME_LEN];    /* File name */
};



This what I am proposing to add:

     __u8    file_type;        /* See directory file type macros below */


Thank you
Jonny

             reply	other threads:[~2020-05-03 12:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-03 12:52 Jonny Grant [this message]
2020-05-04 22:26 ` /fs/ext4/ext4.h add a comment to ext4_dir_entry_2 Andreas Dilger
2020-05-04 22:39   ` Darrick J. Wong
2020-05-04 23:00     ` Andreas Dilger
2020-05-04 23:14       ` Jonny Grant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bf50e54f-2a0c-17a4-89c3-4afcc298daeb@jguk.org \
    --to=jg@jguk.org \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox