From: Andrey Ryabinin <ryabinin.a.a@gmail.com>
To: Harry Yoo <harry.yoo@oracle.com>,
akpm@linux-foundation.org, vbabka@suse.cz
Cc: andreyknvl@gmail.com, cl@linux.com, dvyukov@google.com,
glider@google.com, hannes@cmpxchg.org, linux-mm@kvack.org,
mhocko@kernel.org, muchun.song@linux.dev, rientjes@google.com,
roman.gushchin@linux.dev, shakeel.butt@linux.dev,
surenb@google.com, vincenzo.frascino@arm.com,
yeoreum.yun@arm.com, tytso@mit.edu, adilger.kernel@dilger.ca,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH V3 7/7] mm/slab: place slabobj_ext metadata in unused space within s->size
Date: Wed, 29 Oct 2025 19:19:29 +0100 [thread overview]
Message-ID: <bf8f2ed4-0b3b-4ddc-9ce9-0d0b1a64c914@gmail.com> (raw)
In-Reply-To: <20251027122847.320924-8-harry.yoo@oracle.com>
On 10/27/25 1:28 PM, Harry Yoo wrote:
> slab->obj_exts |= MEMCG_DATA_OBJEXTS;
> slab_set_stride(slab, sizeof(struct slabobj_ext));
> + } else if (obj_exts_in_object(s)) {
> + unsigned int offset = obj_exts_offset_in_object(s);
> +
> + slab->obj_exts = (unsigned long)slab_address(slab);
> + slab->obj_exts += s->red_left_pad;
> + slab->obj_exts += obj_exts_offset_in_object(s);
> + if (IS_ENABLED(CONFIG_MEMCG))
> + slab->obj_exts |= MEMCG_DATA_OBJEXTS;
> + slab_set_stride(slab, s->size);
> +
> + for_each_object(addr, s, slab_address(slab), slab->objects) {
> + kasan_unpoison_range(addr + offset,
> + sizeof(struct slabobj_ext));
Is this leftover from previous version? Otherwise I don't get why we unpoison this.
> + memset(addr + offset, 0, sizeof(struct slabobj_ext));
> + }
> }
> metadata_access_disable();
> }
next prev parent reply other threads:[~2025-10-29 18:19 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 12:28 [RFC PATCH V3 0/7] mm/slab: reduce slab accounting memory overhead by allocating slabobj_ext metadata within unused slab space Harry Yoo
2025-10-27 12:28 ` [RFC PATCH V3 1/7] mm/slab: allow specifying freepointer offset when using constructor Harry Yoo
2025-10-28 17:43 ` Suren Baghdasaryan
2025-10-29 7:10 ` Harry Yoo
2025-10-30 14:35 ` Vlastimil Babka
2025-10-27 12:28 ` [RFC PATCH V3 2/7] ext4: specify the free pointer offset for ext4_inode_cache Harry Yoo
2025-10-28 17:22 ` Suren Baghdasaryan
2025-10-28 17:25 ` Suren Baghdasaryan
2025-10-27 12:28 ` [RFC PATCH V3 3/7] mm/slab: abstract slabobj_ext access via new slab_obj_ext() helper Harry Yoo
2025-10-28 17:55 ` Suren Baghdasaryan
2025-10-29 8:49 ` Harry Yoo
2025-10-29 15:24 ` Suren Baghdasaryan
2025-10-30 1:26 ` Harry Yoo
2025-10-30 5:03 ` Suren Baghdasaryan
2025-10-27 12:28 ` [RFC PATCH V3 4/7] mm/slab: use stride to access slabobj_ext Harry Yoo
2025-10-28 20:10 ` Suren Baghdasaryan
2025-10-27 12:28 ` [RFC PATCH V3 5/7] mm/memcontrol,alloc_tag: handle slabobj_ext access under KASAN poison Harry Yoo
2025-10-28 23:03 ` Suren Baghdasaryan
2025-10-29 8:06 ` Harry Yoo
2025-10-29 15:28 ` Suren Baghdasaryan
2025-10-27 12:28 ` [RFC PATCH V3 6/7] mm/slab: save memory by allocating slabobj_ext array from leftover Harry Yoo
2025-10-29 3:07 ` Suren Baghdasaryan
2025-10-29 7:59 ` Harry Yoo
2025-10-29 18:37 ` Suren Baghdasaryan
2025-10-30 0:40 ` Harry Yoo
2025-10-30 16:33 ` Vlastimil Babka
2025-10-29 18:45 ` Andrey Ryabinin
2025-10-30 1:11 ` Harry Yoo
2025-10-27 12:28 ` [RFC PATCH V3 7/7] mm/slab: place slabobj_ext metadata in unused space within s->size Harry Yoo
2025-10-29 3:19 ` Suren Baghdasaryan
2025-10-29 18:19 ` Andrey Ryabinin [this message]
2025-10-30 0:51 ` Harry Yoo
2025-10-30 12:41 ` Yeoreum Yun
2025-10-30 16:39 ` [RFC PATCH V3 0/7] mm/slab: reduce slab accounting memory overhead by allocating slabobj_ext metadata within unused slab space Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf8f2ed4-0b3b-4ddc-9ce9-0d0b1a64c914@gmail.com \
--to=ryabinin.a.a@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=cl@linux.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=hannes@cmpxchg.org \
--cc=harry.yoo@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=surenb@google.com \
--cc=tytso@mit.edu \
--cc=vbabka@suse.cz \
--cc=vincenzo.frascino@arm.com \
--cc=yeoreum.yun@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).