From: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
To: David Timber <dxdt@dev.snart.me>, linux-ext4@vger.kernel.org
Cc: David Timber <dxdt@dev.snart.me>
Subject: Re: [PATCH 1/1] filefrag: fix fibmap error message
Date: Sat, 14 Mar 2026 18:18:11 +0530 [thread overview]
Message-ID: <bjgqtw50.ritesh.list@gmail.com> (raw)
In-Reply-To: <20260303115637.453629-2-dxdt@dev.snart.me>
David Timber <dxdt@dev.snart.me> writes:
> When an errno other than EINVAL, ENOTTY or EPERM is returned from FIBMAP
> ioctl, the negative errno is passsed to strerror(), which only accepts
> positive errno values.
>
LGTM.
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
> Signed-off-by: David Timber <dxdt@dev.snart.me>
> ---
> misc/filefrag.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/misc/filefrag.c b/misc/filefrag.c
> index 4641714c..d45288cd 100644
> --- a/misc/filefrag.c
> +++ b/misc/filefrag.c
> @@ -517,7 +517,7 @@ static int frag_report(const char *filename)
> filename);
> } else {
> fprintf(stderr, "%s: FIBMAP error: %s",
> - filename, strerror(expected));
> + filename, strerror(-expected));
> }
> rc = expected;
> goto out_close;
> --
> 2.53.0.1.ga224b40d3f.dirty
prev parent reply other threads:[~2026-03-14 12:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 11:55 [PATCH 0/1] filefrag: fix fibmap error message David Timber
2026-03-03 11:55 ` [PATCH 1/1] " David Timber
2026-03-03 18:38 ` Andreas Dilger
2026-03-14 12:48 ` Ritesh Harjani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bjgqtw50.ritesh.list@gmail.com \
--to=ritesh.list@gmail.com \
--cc=dxdt@dev.snart.me \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox