[PATCH 0/1] filefrag: fix fibmap error message

[PATCH 0/1] filefrag: fix fibmap error message

[David Timber]

There's a silly mistake in misc/filefrag.c. It's a single character
change.

get_block() of various fs can return any errno at all. FUSE is
especially wild west out there and the fact that POSIX allowing NULL
and Musl simply refusing to snprintf() doesn't really help either...

David Timber (1):
  filefrag: fix fibmap error message

 misc/filefrag.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.53.0.1.ga224b40d3f.dirty

[PATCH 1/1] filefrag: fix fibmap error message

[David Timber]

When an errno other than EINVAL, ENOTTY or EPERM is returned from FIBMAP
ioctl, the negative errno is passsed to strerror(), which only accepts
positive errno values.

Signed-off-by: David Timber <dxdt@dev.snart.me>
---
 misc/filefrag.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/misc/filefrag.c b/misc/filefrag.c
index 4641714c..d45288cd 100644
--- a/misc/filefrag.c
+++ b/misc/filefrag.c
@@ -517,7 +517,7 @@ static int frag_report(const char *filename)
 					filename);
 			} else {
 				fprintf(stderr, "%s: FIBMAP error: %s",
-					filename, strerror(expected));
+					filename, strerror(-expected));
 			}
 			rc = expected;
 			goto out_close;
-- 
2.53.0.1.ga224b40d3f.dirty

Re: [PATCH 1/1] filefrag: fix fibmap error message

[Andreas Dilger]

On Mar 3, 2026, at 04:55, David Timber <dxdt@dev.snart.me> wrote:
> 
> When an errno other than EINVAL, ENOTTY or EPERM is returned from FIBMAP
> ioctl, the negative errno is passsed to strerror(), which only accepts
> positive errno values.
> 
> Signed-off-by: David Timber <dxdt@dev.snart.me>

Reviewed-by: Andreas Dilger <adilger@dilger.ca <mailto:adilger@dilger.ca>>

> ---
> misc/filefrag.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/misc/filefrag.c b/misc/filefrag.c
> index 4641714c..d45288cd 100644
> --- a/misc/filefrag.c
> +++ b/misc/filefrag.c
> @@ -517,7 +517,7 @@ static int frag_report(const char *filename)
> filename);
>  			} else {
>  				fprintf(stderr, "%s: FIBMAP error: %s",
> -					filename, strerror(expected));
> +					filename, strerror(-expected));
>  			}
>  			rc = expected;
>  			goto out_close;
> -- 
> 2.53.0.1.ga224b40d3f.dirty
> 
> 

Re: [PATCH 1/1] filefrag: fix fibmap error message

[Ritesh Harjani]

David Timber <dxdt@dev.snart.me> writes:

> When an errno other than EINVAL, ENOTTY or EPERM is returned from FIBMAP
> ioctl, the negative errno is passsed to strerror(), which only accepts
> positive errno values.
>

LGTM.
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>

> Signed-off-by: David Timber <dxdt@dev.snart.me>
> ---
>  misc/filefrag.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/misc/filefrag.c b/misc/filefrag.c
> index 4641714c..d45288cd 100644
> --- a/misc/filefrag.c
> +++ b/misc/filefrag.c
> @@ -517,7 +517,7 @@ static int frag_report(const char *filename)
>  					filename);
>  			} else {
>  				fprintf(stderr, "%s: FIBMAP error: %s",
> -					filename, strerror(expected));
> +					filename, strerror(-expected));
>  			}
>  			rc = expected;
>  			goto out_close;
> -- 
> 2.53.0.1.ga224b40d3f.dirty