* [Bug 12676] fs/ext4/extents.c: In function ‘ext4 ext search right’: fs/ext4/extents.c:1120: warning: ‘ix’ may be used uninitialized in this function
2009-02-09 11:15 [Bug 12676] New: fs/ext4/extents.c: In function ‘ext4 ext search right’: fs/ext4/extents.c:1120: warning: ‘ix’ may be used uninitialized in this function bugme-daemon
@ 2009-02-09 16:10 ` bugme-daemon
2009-02-10 13:25 ` [Bug 12676] New: " Theodore Tso
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: bugme-daemon @ 2009-02-09 16:10 UTC (permalink / raw)
To: linux-ext4
http://bugzilla.kernel.org/show_bug.cgi?id=12676
------- Comment #1 from sandeen@redhat.com 2009-02-09 08:10 -------
I think this is fixed upstream; you say in the bug metadata that this is
version 2.6.28.4 but the first comment says 2.6.29-rc* - which is it?
--
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Bug 12676] New: fs/ext4/extents.c: In function ‘ext4 ext search right’: fs/ext4/extents.c:1120: warning: ‘ix’ may be used uninitialized in this function
2009-02-09 11:15 [Bug 12676] New: fs/ext4/extents.c: In function ‘ext4 ext search right’: fs/ext4/extents.c:1120: warning: ‘ix’ may be used uninitialized in this function bugme-daemon
2009-02-09 16:10 ` [Bug 12676] " bugme-daemon
@ 2009-02-10 13:25 ` Theodore Tso
2009-02-10 18:21 ` [Bug 12676] " bugme-daemon
2009-05-19 18:36 ` [Bug 12676] fs/ext4/extents.c: In function ‘ext4_ext_search_right’: " bugzilla-daemon
3 siblings, 0 replies; 5+ messages in thread
From: Theodore Tso @ 2009-02-10 13:25 UTC (permalink / raw)
To: bugme-daemon; +Cc: linux-ext4
On Mon, Feb 09, 2009 at 03:15:49AM -0800, bugme-daemon@bugzilla.kernel.org wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=12676
>
> Summary: fs/ext4/extents.c: In function
> ‘ext4_ext_search_right’: fs/ext4/extents.c:1120:
> warning: ‘ix’ may be used uninitialized in this
> function
> When compiling gets this error on Ext4 FS:
> "fs/ext4/extents.c: In function ‘ext4_ext_search_right’:
> fs/ext4/extents.c:1120: warning: ‘ix’ may be used uninitialized in this
> function
> "
What version of gcc are you using to compile your kernel? This looks
like the case of "gcc is stupid not to notice that depth must be
non-zero, so ix is always initialized". Which doesn't seem to be the
case with gcc 4.3.2, but it might be true with an older version of
gcc.
We can shut up gcc by forcibly initializing ix, but if this is only a
problem with older gcc's, as it seems, it's probably best not to
clutter the source (and the compiled binary) with an unneeded
initialization:
/* go up and search for index to the right */
while (--depth >= 0) {
ix = path[depth].p_idx;
if (ix != EXT_LAST_INDEX(path[depth].p_hdr))
goto got_index;
}
/* we've gone up to the root and found no index to the right */
return 0;
got_index:
/* we've found index to the right, let's
* follow it and find the closest allocated
* block to the right */
ix++;
^^^^^ Gee, aren't (some verions of) gcc stupid?
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread* [Bug 12676] fs/ext4/extents.c: In function ‘ext4 ext search right’: fs/ext4/extents.c:1120: warning: ‘ix’ may be used uninitialized in this function
2009-02-09 11:15 [Bug 12676] New: fs/ext4/extents.c: In function ‘ext4 ext search right’: fs/ext4/extents.c:1120: warning: ‘ix’ may be used uninitialized in this function bugme-daemon
2009-02-09 16:10 ` [Bug 12676] " bugme-daemon
2009-02-10 13:25 ` [Bug 12676] New: " Theodore Tso
@ 2009-02-10 18:21 ` bugme-daemon
2009-05-19 18:36 ` [Bug 12676] fs/ext4/extents.c: In function ‘ext4_ext_search_right’: " bugzilla-daemon
3 siblings, 0 replies; 5+ messages in thread
From: bugme-daemon @ 2009-02-10 18:21 UTC (permalink / raw)
To: linux-ext4
http://bugzilla.kernel.org/show_bug.cgi?id=12676
------- Comment #2 from tytso@mit.edu 2009-02-10 10:21 -------
On Mon, Feb 09, 2009 at 03:15:49AM -0800, bugme-daemon@bugzilla.kernel.org
wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=12676
>
> Summary: fs/ext4/extents.c: In function
> ‘ext4_ext_search_right’: fs/ext4/extents.c:1120:
> warning: ‘ix’ may be used uninitialized in this
> function
> When compiling gets this error on Ext4 FS:
> "fs/ext4/extents.c: In function ‘ext4_ext_search_right’:
> fs/ext4/extents.c:1120: warning: ‘ix’ may be used uninitialized in this
> function
> "
What version of gcc are you using to compile your kernel? This looks
like the case of "gcc is stupid not to notice that depth must be
non-zero, so ix is always initialized". Which doesn't seem to be the
case with gcc 4.3.2, but it might be true with an older version of
gcc.
We can shut up gcc by forcibly initializing ix, but if this is only a
problem with older gcc's, as it seems, it's probably best not to
clutter the source (and the compiled binary) with an unneeded
initialization:
/* go up and search for index to the right */
while (--depth >= 0) {
ix = path[depth].p_idx;
if (ix != EXT_LAST_INDEX(path[depth].p_hdr))
goto got_index;
}
/* we've gone up to the root and found no index to the right */
return 0;
got_index:
/* we've found index to the right, let's
* follow it and find the closest allocated
* block to the right */
ix++;
^^^^^ Gee, aren't (some verions of) gcc stupid?
- Ted
--
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread* [Bug 12676] fs/ext4/extents.c: In function ‘ext4_ext_search_right’: fs/ext4/extents.c:1120: warning: ‘ix’ may be used uninitialized in this function
2009-02-09 11:15 [Bug 12676] New: fs/ext4/extents.c: In function ‘ext4 ext search right’: fs/ext4/extents.c:1120: warning: ‘ix’ may be used uninitialized in this function bugme-daemon
` (2 preceding siblings ...)
2009-02-10 18:21 ` [Bug 12676] " bugme-daemon
@ 2009-05-19 18:36 ` bugzilla-daemon
3 siblings, 0 replies; 5+ messages in thread
From: bugzilla-daemon @ 2009-05-19 18:36 UTC (permalink / raw)
To: linux-ext4
http://bugzilla.kernel.org/show_bug.cgi?id=12676
Theodore Tso <tytso@mit.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
CC| |tytso@mit.edu
Resolution| |UNREPRODUCIBLE
Regression|--- |No
--- Comment #3 from Theodore Tso <tytso@mit.edu> 2009-05-19 18:36:00 ---
No response from the person filing the bug, and I don't see any compiler
warnings gcc 4.3.x, so I'm closing this bug.
--
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.
^ permalink raw reply [flat|nested] 5+ messages in thread