From: bugzilla-daemon@bugzilla.kernel.org
To: linux-ext4@vger.kernel.org
Subject: [Bug 201631] WARNING: CPU: 11 PID: 29593 at fs/ext4/inode.c:3927 .ext4_set_page_dirty+0x70/0xb0
Date: Wed, 19 Dec 2018 13:39:16 +0000 [thread overview]
Message-ID: <bug-201631-13602-9EcHd7Mjso@https.bugzilla.kernel.org/> (raw)
In-Reply-To: <bug-201631-13602@https.bugzilla.kernel.org/>
https://bugzilla.kernel.org/show_bug.cgi?id=201631
--- Comment #21 from Jan Kara (jack@suse.cz) ---
(In reply to Benjamin Herrenschmidt from comment #20)
> Pardon my ignorance here, but I was under the impression that this was
> normal :) The whole point being that the PTE dirty bit gets set when
> accesses happen, and latter on gets harvested into the struct page dirty bit.
>
> Otherwise, what would be the point of having a PTE dirty bit in the PTE at
> all or transferring a dirty bit from PTE to struct page in
> try_to_unmap_one() (for example) if a writable page is always mapped dirty ?
The PTE dirty bit is used for anonymous pages as you describe. File pages are
marked dirty immediately during page fault (look for example at
mm/memory.c:wp_page_shared() and its call to fault_dirty_shared_page()). When
page gets written back, clear_page_dirty_for_io() is used which writeprotects
all PTEs, clears PTE dirty bits, and then page dirty bit is cleared as well. So
for shared file mappings PTE dirty bits could be ignored.
The reason why PTE dirty bits are not ignored are partly heritage from before
2006 when this mechanism was introduced and party because people do it "just to
be sure"...
--
You are receiving this mail because:
You are watching the assignee of the bug.
next prev parent reply other threads:[~2018-12-19 13:39 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 18:14 [Bug 201631] New: WARNING: CPU: 11 PID: 29593 at fs/ext4/inode.c:3927 .ext4_set_page_dirty+0x70/0xb0 bugzilla-daemon
2018-11-07 18:14 ` [Bug 201631] " bugzilla-daemon
2018-11-07 22:09 ` bugzilla-daemon
2018-11-08 11:44 ` bugzilla-daemon
2018-11-28 10:41 ` bugzilla-daemon
2018-11-28 11:00 ` bugzilla-daemon
2018-11-28 17:14 ` bugzilla-daemon
2018-11-28 17:19 ` bugzilla-daemon
2018-12-11 11:21 ` bugzilla-daemon
2018-12-16 13:26 ` bugzilla-daemon
2018-12-16 13:27 ` bugzilla-daemon
2018-12-16 20:47 ` bugzilla-daemon
2018-12-17 10:58 ` bugzilla-daemon
2018-12-17 11:30 ` bugzilla-daemon
2018-12-17 11:51 ` bugzilla-daemon
2018-12-17 12:15 ` bugzilla-daemon
2018-12-17 16:51 ` bugzilla-daemon
2018-12-17 16:52 ` bugzilla-daemon
2018-12-17 17:50 ` bugzilla-daemon
2018-12-18 8:45 ` bugzilla-daemon
2018-12-18 22:27 ` bugzilla-daemon
2018-12-19 13:39 ` bugzilla-daemon [this message]
2018-12-19 17:03 ` bugzilla-daemon
2018-12-19 22:58 ` bugzilla-daemon
2018-12-19 23:03 ` bugzilla-daemon
2018-12-20 4:15 ` bugzilla-daemon
2018-12-20 4:21 ` bugzilla-daemon
2018-12-20 7:41 ` bugzilla-daemon
2018-12-20 7:49 ` bugzilla-daemon
2018-12-20 8:21 ` bugzilla-daemon
2018-12-20 8:35 ` bugzilla-daemon
2018-12-20 9:10 ` bugzilla-daemon
2018-12-20 9:29 ` bugzilla-daemon
2018-12-21 0:26 ` bugzilla-daemon
2018-12-21 11:16 ` bugzilla-daemon
2018-12-21 11:17 ` bugzilla-daemon
2018-12-21 11:52 ` bugzilla-daemon
2018-12-21 23:47 ` bugzilla-daemon
2018-12-22 14:13 ` bugzilla-daemon
2019-01-02 15:10 ` bugzilla-daemon
2019-01-02 15:46 ` bugzilla-daemon
2019-01-08 23:00 ` bugzilla-daemon
2019-01-08 23:02 ` bugzilla-daemon
2019-01-17 10:32 ` bugzilla-daemon
2019-01-17 11:48 ` bugzilla-daemon
2019-01-22 23:09 ` bugzilla-daemon
2019-01-22 23:10 ` bugzilla-daemon
2019-01-23 16:40 ` bugzilla-daemon
2019-01-23 16:41 ` bugzilla-daemon
2019-01-23 16:42 ` bugzilla-daemon
2019-01-24 3:17 ` bugzilla-daemon
2019-01-24 3:40 ` bugzilla-daemon
2019-01-24 8:15 ` bugzilla-daemon
2019-01-26 16:03 ` bugzilla-daemon
2019-01-27 14:48 ` bugzilla-daemon
2019-01-29 9:40 ` bugzilla-daemon
2019-01-29 9:41 ` bugzilla-daemon
2019-01-29 12:13 ` bugzilla-daemon
2019-01-29 14:48 ` bugzilla-daemon
2019-01-30 12:53 ` bugzilla-daemon
2019-01-30 12:59 ` bugzilla-daemon
2019-01-31 0:31 ` bugzilla-daemon
2019-01-31 0:32 ` bugzilla-daemon
2019-01-31 9:10 ` bugzilla-daemon
2019-02-04 6:37 ` bugzilla-daemon
2019-02-04 6:38 ` bugzilla-daemon
2019-02-04 6:39 ` bugzilla-daemon
2019-02-04 22:30 ` bugzilla-daemon
2019-02-04 22:33 ` bugzilla-daemon
2019-02-05 8:42 ` bugzilla-daemon
2019-02-05 9:21 ` bugzilla-daemon
2019-02-05 11:43 ` bugzilla-daemon
2019-02-05 12:21 ` bugzilla-daemon
2019-02-07 9:06 ` bugzilla-daemon
2019-02-07 11:29 ` bugzilla-daemon
2019-02-07 13:03 ` bugzilla-daemon
2019-02-07 13:05 ` bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-201631-13602-9EcHd7Mjso@https.bugzilla.kernel.org/ \
--to=bugzilla-daemon@bugzilla.kernel.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).