From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C6EAC282C4 for ; Mon, 4 Feb 2019 06:37:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 35D992177E for ; Mon, 4 Feb 2019 06:37:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725903AbfBDGhK convert rfc822-to-8bit (ORCPT ); Mon, 4 Feb 2019 01:37:10 -0500 Received: from mail.wl.linuxfoundation.org ([198.145.29.98]:34382 "EHLO mail.wl.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725824AbfBDGhK (ORCPT ); Mon, 4 Feb 2019 01:37:10 -0500 Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8CDE62AE44 for ; Mon, 4 Feb 2019 06:37:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 816FE2AE6E; Mon, 4 Feb 2019 06:37:09 +0000 (UTC) From: bugzilla-daemon@bugzilla.kernel.org To: linux-ext4@vger.kernel.org Subject: [Bug 201631] WARNING: CPU: 11 PID: 29593 at fs/ext4/inode.c:3927 .ext4_set_page_dirty+0x70/0xb0 Date: Mon, 04 Feb 2019 06:37:07 +0000 X-Bugzilla-Reason: None X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: AssignedTo fs_ext4@kernel-bugs.osdl.org X-Bugzilla-Product: File System X-Bugzilla-Component: ext4 X-Bugzilla-Version: 2.5 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: aneesh.kumar@linux.ibm.com X-Bugzilla-Status: NEW X-Bugzilla-Resolution: X-Bugzilla-Priority: P1 X-Bugzilla-Assigned-To: fs_ext4@kernel-bugs.osdl.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Bugzilla-URL: https://bugzilla.kernel.org/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org https://bugzilla.kernel.org/show_bug.cgi?id=201631 --- Comment #63 from Aneesh Kumar KV (aneesh.kumar@linux.ibm.com) --- (In reply to Jan Kara from comment #62) > Erhard, thanks for the results! They are very weird but pretty clear: > cleaned state is 0x10 so page_vma_mapped_walk() called from page_mkclean() > has bailed out somewhere between: > > if (bh) > bh->b_cleaned_state |= 16; > restart: > pgd = pgd_offset(mm, pvmw->address); > if (!pgd_present(*pgd)) > return false; > p4d = p4d_offset(pgd, pvmw->address); > if (!p4d_present(*p4d)) > return false; > pud = pud_offset(p4d, pvmw->address); > if (!pud_present(*pud)) > return false; > if (bh) > bh->b_cleaned_state |= 32; > > I really don't understand how any of these tests could fail when later > unmap_page_range() has found the pte. But I somehow suspect commit > da7ad366b497f5 "powerpc/mm/book3s: Update pmd_present to look at > _PAGE_PRESENT bit" could be related since it was introduced in the window > where the problems started happening and it touches relevant code. > > Aneesh, what needs to be reverted so that we can test that this commit is > indeed the problematic one? I suppose: > > da7ad366b497 "powerpc/mm/book3s: Update pmd_present to look at _PAGE_PRESENT > bit" > f1981b5b302f "powerpc/mm/hugetlb/book3s: add _PAGE_PRESENT to hugepd > pointer." > ae28f17b5eeb "powerpc/mm/book3s: Check for pmd_large instead of > pmd_trans_huge" > 75646c480fde "arch/powerpc/mm/hash: validate the pte entries before handling > the hash fault" > 8890e03380d3 "powerpc/mm/thp: update pmd_trans_huge to check for pmd_present" > a0820ff33451 "powerpc/mm:book3s: Enable THP migration support" We can revert the first and the last patch. I am attaching the patches this got the revert failures fixed. -aneesh -- You are receiving this mail because: You are watching the assignee of the bug.