[Bug 216781] New: wrong check buffer_head in ext4_simulate_fail_bh

[Bug 216781] New: wrong check buffer_head in ext4_simulate_fail_bh

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216781

            Bug ID: 216781
           Summary: wrong check buffer_head in ext4_simulate_fail_bh
           Product: File System
           Version: 2.5
    Kernel Version: 6.0
          Hardware: All
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: low
          Priority: P1
         Component: ext4
          Assignee: fs_ext4@kernel-bugs.osdl.org
          Reporter: 1527030098@qq.com
        Regression: No

ext4_simulate_fail_bh used at
https://elixir.bootlin.com/linux/latest/source/fs/ext4/inode.c#L4574
but it seems bh(buffer_head) can only be ptr or NULL, so it is wrong to use
IS_ERR in ext4_simulate_fail_bh at
https://elixir.bootlin.com/linux/latest/source/fs/ext4/ext4.h#L1855

replace IS_ERR with IS_ERR_OR_NULL here.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 216781] wrong check buffer_head in ext4_simulate_fail_bh

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=216781

eriri (1527030098@qq.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #1 from eriri (1527030098@qq.com) ---
Oops，it's my mistake.

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.