From: bugzilla-daemon@kernel.org
To: linux-ext4@vger.kernel.org
Subject: [Bug 216781] New: wrong check buffer_head in ext4_simulate_fail_bh
Date: Wed, 07 Dec 2022 03:06:11 +0000 [thread overview]
Message-ID: <bug-216781-13602@https.bugzilla.kernel.org/> (raw)
https://bugzilla.kernel.org/show_bug.cgi?id=216781
Bug ID: 216781
Summary: wrong check buffer_head in ext4_simulate_fail_bh
Product: File System
Version: 2.5
Kernel Version: 6.0
Hardware: All
OS: Linux
Tree: Mainline
Status: NEW
Severity: low
Priority: P1
Component: ext4
Assignee: fs_ext4@kernel-bugs.osdl.org
Reporter: 1527030098@qq.com
Regression: No
ext4_simulate_fail_bh used at
https://elixir.bootlin.com/linux/latest/source/fs/ext4/inode.c#L4574
but it seems bh(buffer_head) can only be ptr or NULL, so it is wrong to use
IS_ERR in ext4_simulate_fail_bh at
https://elixir.bootlin.com/linux/latest/source/fs/ext4/ext4.h#L1855
replace IS_ERR with IS_ERR_OR_NULL here.
--
You may reply to this email to add a comment.
You are receiving this mail because:
You are watching the assignee of the bug.
next reply other threads:[~2022-12-07 3:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 3:06 bugzilla-daemon [this message]
2022-12-07 3:12 ` [Bug 216781] wrong check buffer_head in ext4_simulate_fail_bh bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-216781-13602@https.bugzilla.kernel.org/ \
--to=bugzilla-daemon@kernel.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox