[Bug 220342] New: After file delete, extent index structure remains unchanged

[Bug 220342] New: After file delete, extent index structure remains unchanged

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=220342

            Bug ID: 220342
           Summary: After file delete, extent index structure remains
                    unchanged
           Product: File System
           Version: 2.5
    Kernel Version: 6.16-rc6
          Hardware: All
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P3
         Component: ext4
          Assignee: fs_ext4@kernel-bugs.osdl.org
          Reporter: bretznic@gmail.com
        Regression: No

Created attachment 308380
  --> https://bugzilla.kernel.org/attachment.cgi?id=308380&action=edit
ext

When a file without extents is deleted, eh_entries and eh_depth are cleared, as
well as ee_start_hi and ee_start_lo.

When a file with extents is deleted, eh_entries and eh_depth are also cleared,
but ei_leaf_hi and ei_leaf_lo are not cleared in the top inode.

The attached screenshots of hexdumps show the issue before vs. after deletion,
for non-extent and extent files.

With ei_leaf_hi and ei_leaf_lo still present, it's easy to reach the data
blocks.

Having said this, extent files have (regular) extent structures lower in the
tree, and those are not cleared. (Unlike the regular extent structures of
non-extent files)

I don't know if it's worth clearing those structures as well. I guess for most
instances it's not, and for security conscious users it would probably be a
nice to have. But then, where to stop? I don't know...

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 220342] After file delete, extent index structure remains unchanged

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=220342

--- Comment #1 from Nicolas Bretz (bretznic@gmail.com) ---
Created attachment 308381
  --> https://bugzilla.kernel.org/attachment.cgi?id=308381&action=edit
patch

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 220342] After file delete, extent index structure remains unchanged

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=220342

--- Comment #2 from Nicolas Bretz (bretznic@gmail.com) ---
CORRECTION: 

I kept making a mistake in my initial description of the issue.

When I said "non-extent", it should actually be "non-index extent".

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.

[Bug 220342] After file delete, extent index structure remains unchanged

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=220342

Nicolas Bretz (bretznic@gmail.com) changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #308381|0                           |1
        is obsolete|                            |

--- Comment #3 from Nicolas Bretz (bretznic@gmail.com) ---
Created attachment 308387
  --> https://bugzilla.kernel.org/attachment.cgi?id=308387&action=edit
correction

-- 
You may reply to this email to add a comment.

You are receiving this mail because:
You are watching the assignee of the bug.