[Bug 24282] New: linux/ext2_fs.h uses defines from linux/fs.h

[Bug 24282] New: linux/ext2_fs.h uses defines from linux/fs.h

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=24282

           Summary: linux/ext2_fs.h uses defines from linux/fs.h
           Product: File System
           Version: 2.5
    Kernel Version: 2.6.33.4
          Platform: All
        OS/Version: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: ext2
        AssignedTo: fs_ext2@kernel-bugs.osdl.org
        ReportedBy: sliwa@blue.cft.edu.pl
        Regression: No


An inline function from linux/ext2_fs.h does not compile without including
linux/fs.h.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 24282] linux/ext2_fs.h uses defines from linux/fs.h

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=24282


Eric Sandeen <sandeen@redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sandeen@redhat.com




--- Comment #1 from Eric Sandeen <sandeen@redhat.com>  2010-12-03 15:13:08 ---
Please attach your config and the compile error that you get, thanks.

-Eric

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 24282] linux/ext2_fs.h uses defines from linux/fs.h

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=24282





--- Comment #2 from Cezary Sliwa <sliwa@blue.cft.edu.pl>  2010-12-03 15:20:24 ---

The error occured when compiling a user space program. Just include
linux/ext2_fs.h whithout linux/fs.h and you get:

/usr/include/linux/ext2_fs.h: In function 'ext2_mask_flags':
/usr/include/linux/ext2_fs.h:182: error: 'FS_DIRSYNC_FL' undeclared (first use
in this function)
/usr/include/linux/ext2_fs.h:182: error: (Each undeclared identifier is
reported only once
/usr/include/linux/ext2_fs.h:182: error: for each function it appears in.)
/usr/include/linux/ext2_fs.h:182: error: 'FS_TOPDIR_FL' undeclared (first use
in this function)
/usr/include/linux/ext2_fs.h:184: error: 'FS_NODUMP_FL' undeclared (first use
in this function)
/usr/include/linux/ext2_fs.h:184: error: 'FS_NOATIME_FL' undeclared (first use
in this function)

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 24282] linux/ext2_fs.h uses defines from linux/fs.h

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=24282





--- Comment #3 from Eric Sandeen <sandeen@redhat.com>  2010-12-03 15:58:32 ---
ah, userspace.  Thanks, that wasn't clear.

commit 36695673b012096228ebdc1b39a6a5850daa474e
Author: David Howells <dhowells@redhat.com>
Date:   Tue Aug 29 19:06:16 2006 +0100

    [PATCH] BLOCK: Move common FS-specific ioctls to linux/fs.h [try #6]

changed to use those FS_ flags; maybe one of the existing #includes used to
pull in fs.h, not sure.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.

[Bug 24282] linux/ext2_fs.h uses defines from linux/fs.h

[bugzilla-daemon]

https://bugzilla.kernel.org/show_bug.cgi?id=24282


Eric Sandeen <sandeen@redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|fs_ext2@kernel-bugs.osdl.or |sandeen@redhat.com
                   |g                           |




--- Comment #4 from Eric Sandeen <sandeen@redhat.com>  2010-12-03 16:27:02 ---
I sent a patch upstream for this.

-- 
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.