From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BA29C2D0E4 for ; Thu, 19 Nov 2020 04:25:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DAC2022258 for ; Thu, 19 Nov 2020 04:25:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726089AbgKSEZT (ORCPT ); Wed, 18 Nov 2020 23:25:19 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:7934 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725964AbgKSEZT (ORCPT ); Wed, 18 Nov 2020 23:25:19 -0500 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4Cc6656llwz6v2R; Thu, 19 Nov 2020 12:25:01 +0800 (CST) Received: from [10.174.179.106] (10.174.179.106) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.487.0; Thu, 19 Nov 2020 12:25:08 +0800 Subject: Re: [Bug report] journal data mode trigger panic in jbd2_journal_commit_transaction To: Mauricio Oliveira CC: "Theodore Y . Ts'o" , , Jan Kara , , "zhangyi (F)" , Hou Tao , , Ye Bin , References: <68b9650e-bef2-69e2-ab5e-8aaddaf46cfe@huawei.com> From: yangerkun Message-ID: Date: Thu, 19 Nov 2020 12:25:08 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.106] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org 在 2020/11/16 21:50, Mauricio Oliveira 写道: > Hi Kun, > > On Sat, Nov 14, 2020 at 5:18 AM yangerkun wrote: >> While using ext4 with data=journal(3.10 kernel), we meet a problem that >> we think may never happend... > [...] > > Could you please confirm you mean 5.10-rc* kernel instead of 3.10? > (It seems so as you mention a recent commit below.) Thanks! > >> For now, what I have seen that can dirty buffer directly is >> ext4_page_mkwrite(64a9f1449950 ("ext4: data=journal: fixes for >> ext4_page_mkwrite()")), and runing ext4_punch_hole with keep_size >> /ext4_page_mkwrite parallel can trigger above warning easily. > [...] > > Hi, Sorry for the long delay reply... And thanks a lot for your advise! The bug trigger with a very low probability. So won't trigger with 5.10 can not prove no bug exist in 5.10. Google a lot and notice that someone before has report the same bug[1]. '3b136499e906 ("ext4: fix data corruption in data=journal mode")' seems fix the problem. I will try to understand this, and give a analysis about how to reproduce it! Thanks, Kun.