From: Eugen Hristev <eugen.hristev@collabora.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org, jaegeuk@kernel.org,
adilger.kernel@dilger.ca, tytso@mit.edu, krisman@suse.de,
brauner@kernel.org, jack@suse.cz, viro@zeniv.linux.org.uk,
kernel@collabora.com,
Gabriel Krisman Bertazi <krisman@collabora.com>
Subject: Re: [PATCH v17 3/7] libfs: Introduce case-insensitive string comparison helper
Date: Fri, 31 May 2024 13:12:59 +0300 [thread overview]
Message-ID: <c6d7ddfe-9e16-4836-b285-d43dd16853fe@collabora.com> (raw)
In-Reply-To: <20240531044851.GE6505@sol.localdomain>
On 5/31/24 07:48, Eric Biggers wrote:
> On Wed, May 29, 2024 at 11:26:30AM +0300, Eugen Hristev via Linux-f2fs-devel wrote:
>> + /*
>> + * Attempt a case-sensitive match first. It is cheaper and
>> + * should cover most lookups, including all the sane
>> + * applications that expect a case-sensitive filesystem.
>> + */
>> +
>> + if (dirent.len == (folded_name->name ? folded_name->len : name->len) &&
>> + !memcmp(name->name, dirent.name, dirent.len))
>> + goto out;
>
> Shouldn't it be just 'name->len' instead of
> '(folded_name->name ? folded_name->len : name->len)'?
Okay, I will change it. I am also waiting for other reviews to prepare the next
version.
Thanks for looking at this.
Eugen
>
> - Eric
> _______________________________________________
> Kernel mailing list -- kernel@mailman.collabora.com
> To unsubscribe send an email to kernel-leave@mailman.collabora.com
> This list is managed by https://mailman.collabora.com
next prev parent reply other threads:[~2024-05-31 10:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-29 8:26 [PATCH v17 0/7] Case insensitive cleanup for ext4/f2fs Eugen Hristev
2024-05-29 8:26 ` [PATCH v17 1/7] ext4: Simplify the handling of cached casefolded names Eugen Hristev
2024-05-29 8:26 ` [PATCH v17 2/7] f2fs: " Eugen Hristev
2024-05-29 8:26 ` [PATCH v17 3/7] libfs: Introduce case-insensitive string comparison helper Eugen Hristev
2024-05-31 4:48 ` Eric Biggers
2024-05-31 10:12 ` Eugen Hristev [this message]
2024-06-04 19:18 ` Gabriel Krisman Bertazi
2024-05-29 8:26 ` [PATCH v17 4/7] ext4: Reuse generic_ci_match for ci comparisons Eugen Hristev
2024-06-04 19:17 ` Gabriel Krisman Bertazi
2024-06-05 10:48 ` Eugen Hristev
2024-05-29 8:26 ` [PATCH v17 5/7] f2fs: " Eugen Hristev
2024-05-29 8:26 ` [PATCH v17 6/7] ext4: Move CONFIG_UNICODE defguards into the code flow Eugen Hristev
2024-05-29 8:26 ` [PATCH v17 7/7] f2fs: " Eugen Hristev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6d7ddfe-9e16-4836-b285-d43dd16853fe@collabora.com \
--to=eugen.hristev@collabora.com \
--cc=adilger.kernel@dilger.ca \
--cc=brauner@kernel.org \
--cc=ebiggers@kernel.org \
--cc=jack@suse.cz \
--cc=jaegeuk@kernel.org \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=krisman@suse.de \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox