From: Eric Sandeen <sandeen@sandeen.net>
To: Jan Kara <jack@suse.cz>, Eric Sandeen <sandeen@redhat.com>
Cc: jack@suse.com, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/2] ext2: convert to the new mount API
Date: Wed, 26 Feb 2025 10:42:11 -0600 [thread overview]
Message-ID: <ca1f1899-455f-4e69-a302-c01acfd565f3@sandeen.net> (raw)
In-Reply-To: <goynv3cssrrdpykmtwon63xiye4qdzbmvpwq6gjzwine63r25n@4mfgf2ycqzql>
On 2/24/25 8:02 AM, Jan Kara wrote:
> On Sun 23-02-25 13:57:40, Eric Sandeen wrote:
>> Convert ext2 to the new mount API.
>>
>> Note that this makes the sb= option more accepting than it was before;
>> previosly, sb= was only accepted if it was the first specified option.
>> Now it can exist anywhere, and if respecified, the last specified value
>> is used.
>>
>> Parse-time messages here are sent to ext2_msg with a NULL sb, and
>> ext2_msg is adjusted to accept that, as ext4 does today as well.
>>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>
> Looks good to me. Thanks!
Thanks Jan - You probably saw the minor nit from the kernel test robot,
"const struct fs_parameter_spec ext2_param_spec" should be static, too.
Sorry about that!
-Eric
next prev parent reply other threads:[~2025-02-26 16:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-23 19:57 [PATCH 0/2] ext2: convert to the new mount API Eric Sandeen
2025-02-23 19:57 ` [PATCH 1/2] " Eric Sandeen
2025-02-24 16:02 ` Jan Kara
2025-02-26 16:42 ` Eric Sandeen [this message]
2025-02-26 17:03 ` Jan Kara
2025-02-23 19:57 ` [PATCH 2/2] ext2: create ext2_msg_fc for use during parsing Eric Sandeen
2025-02-24 16:01 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca1f1899-455f-4e69-a302-c01acfd565f3@sandeen.net \
--to=sandeen@sandeen.net \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox