From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29A8DC433EF for ; Tue, 15 Mar 2022 20:39:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351761AbiCOUk6 (ORCPT ); Tue, 15 Mar 2022 16:40:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351759AbiCOUk5 (ORCPT ); Tue, 15 Mar 2022 16:40:57 -0400 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CAF152B1C for ; Tue, 15 Mar 2022 13:39:42 -0700 (PDT) Received: by mail-pj1-x1029.google.com with SMTP id mm23-20020a17090b359700b001bfceefd8c6so3279774pjb.3 for ; Tue, 15 Mar 2022 13:39:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=qO1EZxPk3EVYZjHmIZj/SC5/lmPYHCVAMvKpVV+UbkI=; b=lNItlz7lqZKKNSvgFx8p5I2NY3GMP9wTeXbVYdrJPCryt0IcrSh18D4QzjcMqzi+HR v+eGGmRhmBAzunxzblrnrfu7bJtD6d1vzXcNdaZt03OvaRZ2SN00vdvN59vTeU34n0BM DFVY1MUc7ddZfaAF1uhPOhnbUUVRqr1wueMc4XuS477LeOWHJ4MROyUXT2sS3whhkzER 1p97lKTeLciQ2wqq6J57y9T9lVn7mrMyG3VQC4V2Liu+6DieALRYZfgJRPJKiOcPcxkw 3EYVqjJR51Ymeb4QTzTpfLFZuVquNHi6hOrAjteVrJOwFhJgEox4WtFeDbsXLXqaMqo+ qsRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=qO1EZxPk3EVYZjHmIZj/SC5/lmPYHCVAMvKpVV+UbkI=; b=CVnzfFFVFzuWCclaNH+LvqXPvl5Y0yNuRLF7nIe6T8je7KiTzZ/AOFBYxYUaG9pXz5 IUhvYuFyg0jLxpX6Ip6J8m1WUFdQu3vPuOH4NL9Vxevs2lxltoYx/pwraWkAt6gXCdAY lCDLMmpjzqJRRbIf47B0UnJD+ySoavx5qL8qUd2eTcPY52Cf7q2+vCZXPRT1ywHw+m0A trpste4tTPJp80aHGLTbFShiC1PNRLf8r8QqVpJIjBdQKiSmEn2EbLB6fG2jib2vXzBU JTuZEgStL4vhLc/SFJubAJECXO+TTAGXJfD2QTMxhr7vXAt+Y1kCJSnF/36PmRZ3f7N4 TBTg== X-Gm-Message-State: AOAM530LBToDgvP8ZYbPAd+HWQoWA661U25Oa2TklFzv7S3bba8xrGJ1 AnaaX51Y0ZMdXcAtxpdpik3TbQ== X-Google-Smtp-Source: ABdhPJyNhIOzgOk4J23C+RNMCO/AhRln4iWu4uKOJZurIutYWkz0FE5iluYGaRnuE5oHnmUO/MOn/Q== X-Received: by 2002:a17:90b:2496:b0:1b9:a6dd:ae7 with SMTP id nt22-20020a17090b249600b001b9a6dd0ae7mr6577592pjb.35.1647376782485; Tue, 15 Mar 2022 13:39:42 -0700 (PDT) Received: from [192.168.254.17] ([50.39.160.154]) by smtp.gmail.com with ESMTPSA id s14-20020a056a0008ce00b004f66dcd4f1csm27714733pfu.32.2022.03.15.13.39.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Mar 2022 13:39:42 -0700 (PDT) Message-ID: Date: Tue, 15 Mar 2022 13:39:41 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH] ext4: check if offset+length is within a valid range in fallocate Content-Language: en-US To: Theodore Ts'o Cc: Andreas Dilger , Ritesh Harjani , linux-ext4@vger.kernel.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+7a806094edd5d07ba029@syzkaller.appspotmail.com References: <20220315191545.187366-1-tadeusz.struk@linaro.org> From: Tadeusz Struk In-Reply-To: <20220315191545.187366-1-tadeusz.struk@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On 3/15/22 12:15, Tadeusz Struk wrote: > @@ -3967,6 +3968,16 @@ int ext4_punch_hole(struct inode *inode, loff_t offset, loff_t length) > offset; > } > > + /* > + * For punch hole the length + offset needs to be at least within > + * one block before last > + */ > + max_length = sbi->s_bitmap_maxbytes - sbi->s_blocksize; that supposed to be: max_length = sbi->s_bitmap_maxbytes - inode->i_sb->s_blocksize; Please ignore this one. I will send a new version soon. Sorry for the noise. > + if (offset + length >= max_length) { > + ret = -ENOSPC; > + goto out_mutex; > + } > + -- Thanks, Tadeusz