linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zhang Yi <yi.zhang@huaweicloud.com>
To: linux-ext4@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org, tytso@mit.edu,
	adilger.kernel@dilger.ca, jack@suse.cz, yi.zhang@huawei.com,
	chengzhihao1@huawei.com, yukuai3@huawei.com
Subject: Re: [PATCH 0/7] ext4: support adding multi-delalloc blocks
Date: Wed, 10 Apr 2024 11:59:33 +0800	[thread overview]
Message-ID: <ccf1b9d9-1126-963e-f6eb-becdbafb81f0@huaweicloud.com> (raw)
In-Reply-To: <20240330120236.3789589-1-yi.zhang@huaweicloud.com>

On 2024/3/30 20:02, Zhang Yi wrote:
> From: Zhang Yi <yi.zhang@huawei.com>
> 
> Hello!
> 
> This patch series is the part 2 prepartory changes of the buffered IO
> iomap conversion, I picked them out from my buffered IO iomap conversion
> RFC series v3[1], and add bigalloc feature support.
> 
> The first 6 patches make ext4_insert_delayed_block() call path support
> inserting multi-delalloc blocks once a time, and the last patch makes
> ext4_da_map_blocks() buffer_head unaware.
> 
> This patch set has been passed 'kvm-xfstests -g auto' tests, I hope it
> could be reviewed and merged first.
> 

I've found an incorrect delalloc reserve space count and incorrect extent
type issue in the current ext4 code while improving my iomap conversion.
I'd suggest to fix this issue first, so please drop this series and look
at my v2 series for details.

Thanks,
Yi.

> [1] https://lore.kernel.org/linux-ext4/20240127015825.1608160-1-yi.zhang@huaweicloud.com/
> 
> Thanks,
> Yi.
> 
> Zhang Yi (7):
>   ext4: trim delalloc extent
>   ext4: drop iblock parameter
>   ext4: make ext4_es_insert_delayed_block() insert multi-blocks
>   ext4: make ext4_da_reserve_space() reserve multi-clusters
>   ext4: factor out check for whether a cluster is allocated
>   ext4: make ext4_insert_delayed_block() insert multi-blocks
>   ext4: make ext4_da_map_blocks() buffer_head unaware
> 
>  fs/ext4/extents_status.c    |  63 +++++++++-----
>  fs/ext4/extents_status.h    |   5 +-
>  fs/ext4/inode.c             | 165 ++++++++++++++++++++++--------------
>  include/trace/events/ext4.h |  26 +++---
>  4 files changed, 162 insertions(+), 97 deletions(-)
> 


      parent reply	other threads:[~2024-04-10  3:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-30 12:02 [PATCH 0/7] ext4: support adding multi-delalloc blocks Zhang Yi
2024-03-30 12:02 ` [PATCH 1/7] ext4: trim delalloc extent Zhang Yi
2024-03-30 12:02 ` [PATCH 2/7] ext4: drop iblock parameter Zhang Yi
2024-03-30 12:02 ` [PATCH 3/7] ext4: make ext4_es_insert_delayed_block() insert multi-blocks Zhang Yi
2024-03-30 12:02 ` [PATCH 4/7] ext4: make ext4_da_reserve_space() reserve multi-clusters Zhang Yi
2024-03-30 12:02 ` [PATCH 5/7] ext4: factor out check for whether a cluster is allocated Zhang Yi
2024-03-30 12:02 ` [PATCH 6/7] ext4: make ext4_insert_delayed_block() insert multi-blocks Zhang Yi
2024-03-30 12:02 ` [PATCH 7/7] ext4: make ext4_da_map_blocks() buffer_head unaware Zhang Yi
2024-04-10  3:59 ` Zhang Yi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ccf1b9d9-1126-963e-f6eb-becdbafb81f0@huaweicloud.com \
    --to=yi.zhang@huaweicloud.com \
    --cc=adilger.kernel@dilger.ca \
    --cc=chengzhihao1@huawei.com \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=yi.zhang@huawei.com \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).