[PATCH v2 0/1] xfs/539: Ignore remount failures on v5 xfs

[PATCH v2 0/1] xfs/539: Ignore remount failures on v5 xfs

[Nirjhar Roy (IBM)]

The test just checks for the deprecation dmesg
warnings when remounted with noattr2 and ikeep, and they appear even if the
remount fails. I wrote the patch because xfs/539 has started failing in one of
our fstests CI runs because RHEL 10 has started disabling xfs v4 support i.e,
CONFIG_XFS_SUPPORT_V4=n. The reason why it was not failing with CONFIG_XFS_SUPPORT_V4=y
is because remount was incorrectly succeeding - reason is explained in [2].

[v1] --> v2
 - Removed patch 2/3 and patch 3/3 for now,
 - For patch 1/3 - Ignore the mount failure instead of skipping noattr2.

[v1] https://lore.kernel.org/all/cover.1739363803.git.nirjhar.roy.lists@gmail.com/
[2] https://lore.kernel.org/all/Z65o6nWxT00MaUrW@dread.disaster.area/


Nirjhar Roy (IBM) (1):
  xfs/539: Ignore remount failures on v5 xfs

 tests/xfs/539 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.34.1

[PATCH v2 1/1] xfs/539: Ignore remount failures on v5 xfs

[Nirjhar Roy (IBM)]

Remount with noattr2 fails on a v5 filesystem, however the deprecation
warnings still get printed and that is exactly what the test
is checking. So ignore the mount failures in this case.

Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com>
---
 tests/xfs/539 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/xfs/539 b/tests/xfs/539
index b9bb7cc1..5098be4a 100755
--- a/tests/xfs/539
+++ b/tests/xfs/539
@@ -61,7 +61,7 @@ for VAR in {attr2,noikeep}; do
 done
 for VAR in {noattr2,ikeep}; do
 	log_tag
-	_scratch_remount $VAR
+	_scratch_remount $VAR >> $seqres.full 2>&1
 	check_dmesg_for_since_tag "XFS: $VAR mount option is deprecated" || \
 		echo "Could not find deprecation warning for $VAR"
 done
-- 
2.34.1

Re: [PATCH v2 1/1] xfs/539: Ignore remount failures on v5 xfs

[Nirjhar Roy (IBM)]

On 3/4/25 19:18, Nirjhar Roy (IBM) wrote:
> Remount with noattr2 fails on a v5 filesystem, however the deprecation
> warnings still get printed and that is exactly what the test
> is checking. So ignore the mount failures in this case.

Hi,

Can I please get some review on this?

--NR

>
> Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com>
> ---
>   tests/xfs/539 | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/xfs/539 b/tests/xfs/539
> index b9bb7cc1..5098be4a 100755
> --- a/tests/xfs/539
> +++ b/tests/xfs/539
> @@ -61,7 +61,7 @@ for VAR in {attr2,noikeep}; do
>   done
>   for VAR in {noattr2,ikeep}; do
>   	log_tag
> -	_scratch_remount $VAR
> +	_scratch_remount $VAR >> $seqres.full 2>&1
>   	check_dmesg_for_since_tag "XFS: $VAR mount option is deprecated" || \
>   		echo "Could not find deprecation warning for $VAR"
>   done

-- 
Nirjhar Roy
Linux Kernel Developer
IBM, Bangalore

Re: [PATCH v2 1/1] xfs/539: Ignore remount failures on v5 xfs

[Pavel Reichl]

On 04/03/2025 14:48, Nirjhar Roy (IBM) wrote:
> Remount with noattr2 fails on a v5 filesystem, however the deprecation
> warnings still get printed and that is exactly what the test
> is checking. So ignore the mount failures in this case.
>
> Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com>
> ---
>   tests/xfs/539 | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/xfs/539 b/tests/xfs/539
> index b9bb7cc1..5098be4a 100755
> --- a/tests/xfs/539
> +++ b/tests/xfs/539
> @@ -61,7 +61,7 @@ for VAR in {attr2,noikeep}; do
>   done
>   for VAR in {noattr2,ikeep}; do
>   	log_tag
> -	_scratch_remount $VAR
> +	_scratch_remount $VAR >> $seqres.full 2>&1
>   	check_dmesg_for_since_tag "XFS: $VAR mount option is deprecated" || \
>   		echo "Could not find deprecation warning for $VAR"
>   done


Reviewed-by: Pavel Reichl <preichl@redhat.com>

Re: [PATCH v2 1/1] xfs/539: Ignore remount failures on v5 xfs

[Nirjhar Roy (IBM)]

On 4/2/25 01:28, Pavel Reichl wrote:
>
> On 04/03/2025 14:48, Nirjhar Roy (IBM) wrote:
>> Remount with noattr2 fails on a v5 filesystem, however the deprecation
>> warnings still get printed and that is exactly what the test
>> is checking. So ignore the mount failures in this case.
>>
>> Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com>
>> ---
>>   tests/xfs/539 | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/xfs/539 b/tests/xfs/539
>> index b9bb7cc1..5098be4a 100755
>> --- a/tests/xfs/539
>> +++ b/tests/xfs/539
>> @@ -61,7 +61,7 @@ for VAR in {attr2,noikeep}; do
>>   done
>>   for VAR in {noattr2,ikeep}; do
>>       log_tag
>> -    _scratch_remount $VAR
>> +    _scratch_remount $VAR >> $seqres.full 2>&1
>>       check_dmesg_for_since_tag "XFS: $VAR mount option is 
>> deprecated" || \
>>           echo "Could not find deprecation warning for $VAR"
>>   done
>
>
> Reviewed-by: Pavel Reichl <preichl@redhat.com>

Thank you for the review.

--NR

-- 
Nirjhar Roy
Linux Kernel Developer
IBM, Bangalore