From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A29F3EB64DD for ; Tue, 25 Jul 2023 02:09:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229987AbjGYCJn (ORCPT ); Mon, 24 Jul 2023 22:09:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229452AbjGYCJm (ORCPT ); Mon, 24 Jul 2023 22:09:42 -0400 Received: from dggsgout11.his.huawei.com (unknown [45.249.212.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F121CA1; Mon, 24 Jul 2023 19:09:40 -0700 (PDT) Received: from mail02.huawei.com (unknown [172.30.67.143]) by dggsgout11.his.huawei.com (SkyGuard) with ESMTP id 4R90pT2QcYz4f3k6d; Tue, 25 Jul 2023 10:09:37 +0800 (CST) Received: from [10.174.178.129] (unknown [10.174.178.129]) by APP2 (Coremail) with SMTP id Syh0CgCHLuzfLr9kz4W0Og--.35121S2; Tue, 25 Jul 2023 10:09:36 +0800 (CST) Subject: Re: [PATCH 00/10] A few fixes and cleanups to mballoc To: Ritesh Harjani , tytso@mit.edu, adilger.kernel@dilger.ca, ojaswin@linux.ibm.com, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org References: <87o7k5jm2b.fsf@doe.com> From: Kemeng Shi Message-ID: Date: Tue, 25 Jul 2023 10:09:35 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <87o7k5jm2b.fsf@doe.com> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 7bit X-CM-TRANSID: Syh0CgCHLuzfLr9kz4W0Og--.35121S2 X-Coremail-Antispam: 1UD129KBjvJXoW7tF1kAr4DCFy7Gw4xuw18Grg_yoW8Jw4rpF Wxua12ka13Gw4xtr4xZ34xJFy8t3yxGFy3Wrn8Wws7ZFyrX34xCan2gr4jvr98Arn3Gw1a qw4avF98Wa4vyFDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUUkjb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k2 6cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4 vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Ar0_tr1l84ACjcxK6xIIjxv20xvEc7Cj xVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIE14v26rxl6s0DM28EF7xvwVC2z280aVCY1x 0267AKxVW0oVCq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG 6I80ewAv7VC0I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFV Cjc4AY6r1j6r4UM4x0Y48IcVAKI48JMxk0xIA0c2IEe2xFo4CEbIxvr21l42xK82IYc2Ij 64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x 8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAKI48JMIIF0xvE 2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42 xK8VAvwI8IcIk0rVWrJr0_WFyUJwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv 6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x07UE-erUUUUU= X-CM-SenderInfo: 5vklyvpphqwq5kxd4v5lfo033gof0z/ X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org on 7/21/2023 11:55 PM, Ritesh Harjani wrote: > Kemeng Shi writes: > >> Hi all, this series contains some random fixes and cleanups to mballoc >> which include correct grp validation, fix data overflow and so on. >> More details can be found in respective patches. >> Besides, 'kvm-xfstest smoke' runs successfully without error. > > Thanks Kemeng for the cleanup series. Looks good to me with few minor > nits which I have commented in individual patches. > Hi Ritesh, thanks for the review and comments. I went through all your suggestions and they help a lot. I will send v2 patchset to handle these. > Note that I couldn't cleanly apply the series on ted's dev branch > (Patch-05 gave some minor conflict). Maybe you might have based your > changes on top of linux master or something. Anyways it was just a minor > conflict and I don't know what is Ted's general preference here, but I > thought of doing an FYI - Sorry for the conflict, this patchset is based on cleanup patchset [1] which you have noticed. As [1] still needs a lot more review, I will make this patchset based on current dev branch. Thanks! [1] https://lore.kernel.org/linux-ext4/20230629144007.1263510-1-shikemeng@huaweicloud.com/T/#m66729346a76498079278df3e132a89910860f8ff -- Best wishes Kemeng Shi