From: liubaolin <liubaolin12138@163.com>
To: Ojaswin Mujoo <ojaswin@linux.ibm.com>
Cc: tytso@mit.edu, adilger.kernel@dilger.ca,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
wangguanyu@vivo.com, Baolin Liu <liubaolin@kylinos.cn>
Subject: Re: [PATCH v1] ext4: add mb_stats_clear for mballoc statistics
Date: Thu, 16 Apr 2026 15:07:28 +0800 [thread overview]
Message-ID: <d4d92271-4f46-4a38-86c9-94b2b8efa504@163.com> (raw)
In-Reply-To: <ad_mguIqaOT-pEmh@li-dc0c254c-257c-11b2-a85c-98b6c1322444.ibm.com>
> Dear ojaswin,
> Alright, thank you for your review. I will revise the patch according to Andreas's comments and submit a second version.
> When submitting the second version, I will also update the relevant files under the Documentation directory according to your suggestions to add explanations.
>
> Regards,
> Baolin
在 2026/4/16 3:26, Ojaswin Mujoo 写道:
> On Tue, Apr 14, 2026 at 06:02:11PM +0800, Baolin Liu wrote:
>> From: Baolin Liu <liubaolin@kylinos.cn>
>>
>> Add a write-only mb_stats_clear sysfs knob to reset ext4 mballoc
>> runtime statistics.This makes it easier to inspect allocator
>> activity for a specific workload instead of using counters
>> accumulated since mount.
>>
>> Signed-off-by: Baolin Liu <liubaolin@kylinos.cn>
>
> The patch looks good to me Baolin. We just need to add documentation of
> this to the Documentation/ABI/testing/sysfs-fs-ext4 file so that the
> users know what it is and the fact that the only value we allow to write
> is 1.
>
> Regards,
> ojaswin
next prev parent reply other threads:[~2026-04-16 7:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-14 10:02 [PATCH v1] ext4: add mb_stats_clear for mballoc statistics Baolin Liu
2026-04-14 10:07 ` liubaolin
2026-04-15 19:26 ` Ojaswin Mujoo
2026-04-16 7:07 ` liubaolin [this message]
2026-04-16 1:14 ` Andreas Dilger
2026-04-16 7:11 ` liubaolin
2026-04-16 1:44 ` Ritesh Harjani
2026-04-16 7:16 ` liubaolin
2026-04-16 8:53 ` Zhang Yi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4d92271-4f46-4a38-86c9-94b2b8efa504@163.com \
--to=liubaolin12138@163.com \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liubaolin@kylinos.cn \
--cc=ojaswin@linux.ibm.com \
--cc=tytso@mit.edu \
--cc=wangguanyu@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox