From: Ritesh Harjani <ritesh.list@gmail.com>
To: stable@vger.kernel.org
Cc: "Theodore Y. Ts'o" <tytso@mit.edu>,
linux-ext4@vger.kernel.org, Jan Kara <jack@suse.cz>,
"Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH] ext4: Don't set dioread_nolock by default for blocksize < pagesize
Date: Mon, 11 May 2020 13:37:59 +0530 [thread overview]
Message-ID: <e61fe76d-687f-3e34-6091-c501071b8a9a@gmail.com> (raw)
In-Reply-To: <20200329021728.GI53396@mit.edu>
Hello stable-list,
I think this subjected patch [1] missed the below fixes tag.
I guess the subjected patch is only picked for 5.7. And
AFAIU, this patch will be needed for 5.6 as well.
Could you please do the needful.
Fixes: 244adf6426ee31a (ext4: make dioread_nolock the default)
[1]:
https://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git/commit/?h=dev&id=626b035b816b61a7a7b4d2205a6807e2f11a18c1
-ritesh
On 3/29/20 7:47 AM, Theodore Y. Ts'o wrote:
> On Sat, Mar 28, 2020 at 01:37:44AM +0530, Ritesh Harjani wrote:
>> Currently on calling echo 3 > drop_caches on host machine, we see
>> FS corruption in the guest. This happens on Power machine where
>> blocksize < pagesize.
>>
>> So as a temporary workaound don't enable dioread_nolock by default
>> for blocksize < pagesize until we identify the root cause.
>>
>> Also emit a warning msg in case if this mount option is manually
>> enabled for blocksize < pagesize.
>>
>> Reported-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>
>> Signed-off-by: Ritesh Harjani <riteshh@linux.ibm.com>
>
> Thanks, applied.
>
> - Ted
>
next prev parent reply other threads:[~2020-05-11 8:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-18 3:47 Ext4 corruption with VM images as 3 > drop_caches Aneesh Kumar K.V
2020-03-19 13:24 ` Ritesh Harjani
2020-03-19 16:36 ` Jan Kara
2020-03-20 4:07 ` Aneesh Kumar K.V
2020-03-20 5:34 ` Ritesh Harjani
2020-03-20 11:49 ` Jan Kara
2020-03-21 3:22 ` Ritesh Harjani
2020-03-27 20:07 ` [PATCH] ext4: Don't set dioread_nolock by default for blocksize < pagesize Ritesh Harjani
2020-03-29 2:17 ` Theodore Y. Ts'o
2020-05-11 8:07 ` Ritesh Harjani [this message]
2020-05-12 11:45 ` Greg KH
2020-05-12 12:50 ` Ritesh Harjani
2020-05-12 12:59 ` Greg KH
2020-05-12 14:13 ` Sasha Levin
2020-05-12 16:12 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e61fe76d-687f-3e34-6091-c501071b8a9a@gmail.com \
--to=ritesh.list@gmail.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).