From: "Manish Katiyar" <mkatiyar@gmail.com>
To: "Theodore Tso" <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org
Subject: [E2FSPROGS, PATCH] Fix "make docs" rule in Makefile for doc folder.
Date: Mon, 14 Apr 2008 17:20:03 +0530 [thread overview]
Message-ID: <ea11fea30804140450l5ee0a0f5o4b18f7fd6e7b6a1d@mail.gmail.com> (raw)
In-Reply-To: <20080413212126.GA18156@mit.edu>
Signed-off-by: Manish Katiyar <mkatiyar@gmail.com>
diff --git a/configure.in b/configure.in
index 5243549..e64d817 100644
--- a/configure.in
+++ b/configure.in
@@ -595,6 +595,20 @@ AC_PATH_PROG(LDCONFIG, ldconfig, :)
AC_CHECK_TOOL(AR, ar, ar)
AC_CHECK_TOOL(RANLIB, ranlib, :)
AC_CHECK_TOOL(STRIP, strip, :)
+AC_CHECK_PROG(MAKEINFO, makeinfo, makeinfo, )
+if test "_$MAKEINFO" = "_"; then
+ MAKEINFO="@echo Makeinfo is missing. Info documentation will not
be built.;true"
+else
+ case "$MAKEINFO" in
+ */missing.*)
+ AC_MSG_WARN([
+*** Makeinfo is missing. Info documentation will not be built.])
+ ;;
+ *)
+ ;;
+ esac
+fi
+AC_SUBST(MAKEINFO)
AC_PROG_INSTALL
# See if we need a separate native compiler.
if test $cross_compiling = no; then
diff --git a/doc/Makefile.in b/doc/Makefile.in
index 5494cf0..9c961f3 100644
--- a/doc/Makefile.in
+++ b/doc/Makefile.in
@@ -13,7 +13,7 @@ INSTALL = @INSTALL@
DVI=texi2dvi
DVIPS=dvips -o "$@"
-INFO=makeinfo
+INFO=@MAKEINFO@
HTML=texi2html
all:: libext2fs.info libext2fs.dvi
On Mon, Apr 14, 2008 at 2:51 AM, Theodore Tso <tytso@mit.edu> wrote:
> On Fri, Apr 11, 2008 at 01:25:47AM +0530, Manish Katiyar wrote:
> > On systems which don't have makeinfo installed by default, "make" or
> > "make docs" fails with the following error
> > /home/mkatiyar/e2fs-git> make docs
> > make[1]: Entering directory `/home/mkatiyar/e2fs-git/doc'
> > MAKEINFO libext2fs.info
> > make[1]: makeinfo: Command not found
> > make[1]: [libext2fs.info] Error 127 (ignored)
> >
> > This patch makes it to bail out with proper error message when
> > makeinfo is not present.
>
> Can you send me a Signed-off-by for your patch, per the
> SUBMITTING-PATCHES file in the e2fsprogs sources?
>
> Many thanks,
>
> - Ted
>
--
Thanks & Regards,
********************************************
Manish Katiyar ( http://mkatiyar.googlepages.com )
3rd Floor, Fair Winds Block
EGL Software Park
Off Intermediate Ring Road
Bangalore 560071, India
***********************************************
prev parent reply other threads:[~2008-04-14 11:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 19:55 [E2FSPROGS, PATCH] Fix "make docs" rule in Makefile for doc folder Manish Katiyar
2008-04-13 21:21 ` Theodore Tso
2008-04-14 11:50 ` Manish Katiyar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea11fea30804140450l5ee0a0f5o4b18f7fd6e7b6a1d@mail.gmail.com \
--to=mkatiyar@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox