[PATCH] resize2fs : Fix potential memory corruption in ext2fs_progress_init()

[PATCH] resize2fs : Fix potential memory corruption in ext2fs_progress_init()

[Manish Katiyar]

Since "prog" is not initialized with 0 , below check in
ext2fs_progress_init() is wrong and may lead to corruptions.


Signed-off-by: Manish Katiyar <mkatiyar@gmail.com>

---
 resize/sim_progress.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/resize/sim_progress.c b/resize/sim_progress.c
index a575633..e7dba88 100644
--- a/resize/sim_progress.c
+++ b/resize/sim_progress.c
@@ -83,7 +83,7 @@ errcode_t ext2fs_progress_init(ext2_sim_progmeter *ret_prog,
        errcode_t               retval;

        retval = ext2fs_get_mem(sizeof(struct ext2_sim_progress), &prog);
-       if (!prog)
+       if (retval)
                return retval;
        memset(prog, 0, sizeof(struct ext2_sim_progress));

-- 
1.5.4.3


Thanks -
Manish

Fwd: [PATCH] resize2fs : Fix potential memory corruption in ext2fs_progress_init()

[Manish Katiyar]

---------- Forwarded message ----------
From: Manish Katiyar <mkatiyar@gmail.com>
Date: Sun, Sep 14, 2008 at 8:02 PM
Subject: [PATCH] resize2fs : Fix potential memory corruption in
ext2fs_progress_init()
To: linux-ext4@vger.kernel.org, Theodore Tso <tytso@mit.edu>
Cc: mkatiyar@gmail.com


Since "prog" is not initialized with 0 , below check in
ext2fs_progress_init() is wrong and may lead to corruptions.


Signed-off-by: Manish Katiyar <mkatiyar@gmail.com>

---
 resize/sim_progress.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/resize/sim_progress.c b/resize/sim_progress.c
index a575633..e7dba88 100644
--- a/resize/sim_progress.c
+++ b/resize/sim_progress.c
@@ -83,7 +83,7 @@ errcode_t ext2fs_progress_init(ext2_sim_progmeter *ret_prog,
       errcode_t               retval;

       retval = ext2fs_get_mem(sizeof(struct ext2_sim_progress), &prog);
-       if (!prog)
+       if (retval)
               return retval;
       memset(prog, 0, sizeof(struct ext2_sim_progress));

--
1.5.4.3


Any ack/nack on this one ?? I also saw some utilities
(debugfs,resizefs) usage don't print the options specified in man
pages. Is it intentional ? Are they hidden options for developers ?

Thanks -
Manish


Thanks -
Manish

Re: [PATCH] resize2fs : Fix potential memory corruption in ext2fs_progress_init()G

[Theodore Tso]

On Sun, Sep 14, 2008 at 08:02:12PM +0530, Manish Katiyar wrote:
> Since "prog" is not initialized with 0 , below check in
> ext2fs_progress_init() is wrong and may lead to corruptions.

Thanks, applied. (Sorry for the delay; I've been really busy the past
two weeks.)

					- Ted