From: Kemeng Shi <shikemeng@huaweicloud.com>
To: Ritesh Harjani <ritesh.list@gmail.com>,
tytso@mit.edu, adilger.kernel@dilger.ca
Cc: ojaswin@linux.ibm.com, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 01/12] ext4: make state in ext4_mb_mark_bb to be bool
Date: Wed, 27 Sep 2023 14:51:28 +0800 [thread overview]
Message-ID: <ec8aca6c-1e8c-3fe9-81d7-d18876cc40cb@huaweicloud.com> (raw)
In-Reply-To: <874jjggn8l.fsf@doe.com>
on 9/27/2023 2:10 PM, Ritesh Harjani wrote:
> Kemeng Shi <shikemeng@huaweicloud.com> writes:
>
>> As state could only be either 0 or 1, just make it bool.
>
> Sure.
>
>>
>> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
>> ---
>> fs/ext4/ext4.h | 2 +-
>> fs/ext4/fast_commit.c | 8 ++++----
>> fs/ext4/mballoc.c | 2 +-
>> 3 files changed, 6 insertions(+), 6 deletions(-)
>
> But why not convert at all places?
Sorry for this. Will convert at all places in next version. Thanks.
>
> git grep "ext4_mb_mark_bb" .
> fs/ext4/ext4.h:extern void ext4_mb_mark_bb(struct super_block *sb, ext4_fsblk_t block,
> fs/ext4/extents.c: ext4_mb_mark_bb(inode->i_sb,
> fs/ext4/extents.c: ext4_mb_mark_bb(inode->i_sb, map.m_pblk, map.m_len, 0);
> fs/ext4/fast_commit.c: ext4_mb_mark_bb(inode->i_sb, map.m_pblk, map.m_len, 0);
> fs/ext4/fast_commit.c: ext4_mb_mark_bb(inode->i_sb, map.m_pblk, map.m_len, 0);
> fs/ext4/fast_commit.c: ext4_mb_mark_bb(inode->i_sb,
> fs/ext4/fast_commit.c: ext4_mb_mark_bb(inode->i_sb, map.m_pblk,
> fs/ext4/mballoc.c:void ext4_mb_mark_bb(struct super_block *sb, ext4_fsblk_t block,
> fs/ext4/mballoc.c: ext4_mb_mark_bb(sb, block, 1, 1);
>
> -ritesh
>
next prev parent reply other threads:[~2023-09-27 6:51 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 20:15 [PATCH v7 00/12] cleanups and unit test for mballoc Kemeng Shi
2023-09-19 20:15 ` [PATCH v7 01/12] ext4: make state in ext4_mb_mark_bb to be bool Kemeng Shi
2023-09-27 6:10 ` Ritesh Harjani
2023-09-27 6:51 ` Kemeng Shi [this message]
2023-09-19 20:15 ` [PATCH v7 02/12] ext4: factor out codes to update block bitmap and group descriptor on disk from ext4_mb_mark_bb Kemeng Shi
2023-09-27 8:49 ` Ritesh Harjani
2023-09-28 3:31 ` Kemeng Shi
2023-09-28 4:42 ` Ritesh Harjani
2023-09-28 7:45 ` Kemeng Shi
2023-09-19 20:15 ` [PATCH v7 03/12] ext4: call ext4_mb_mark_context in ext4_free_blocks_simple Kemeng Shi
2023-09-27 8:52 ` Ritesh Harjani
2023-09-19 20:15 ` [PATCH v7 04/12] ext4: extend ext4_mb_mark_context to support allocation under journal Kemeng Shi
2023-09-27 9:13 ` Ritesh Harjani
2023-09-19 20:15 ` [PATCH v7 05/12] ext4: call ext4_mb_mark_context in ext4_mb_mark_diskspace_used Kemeng Shi
2023-09-27 9:58 ` Ritesh Harjani
2023-09-19 20:15 ` [PATCH v7 06/12] ext4: Separate block bitmap and buddy bitmap freeing in ext4_mb_clear_bb() Kemeng Shi
2023-09-27 11:06 ` Ritesh Harjani
2023-09-19 20:15 ` [PATCH v7 07/12] ext4: call ext4_mb_mark_context in ext4_mb_clear_bb Kemeng Shi
2023-09-27 11:14 ` Ritesh Harjani
2023-09-19 20:15 ` [PATCH v7 08/12] ext4: Separate block bitmap and buddy bitmap freeing in ext4_group_add_blocks() Kemeng Shi
2023-09-27 11:16 ` Ritesh Harjani
2023-09-19 20:15 ` [PATCH v7 09/12] ext4: call ext4_mb_mark_context " Kemeng Shi
2023-09-27 11:19 ` Ritesh Harjani
2023-09-19 20:15 ` [PATCH v7 10/12] ext4: add some kunit stub for mballoc kunit test Kemeng Shi
2023-09-19 20:15 ` [PATCH v7 11/12] ext4: add first unit test for ext4_mb_new_blocks_simple in mballoc Kemeng Shi
2023-09-27 11:39 ` Ritesh Harjani
2023-09-19 20:15 ` [PATCH v7 12/12] ext4: run mballoc test with different layouts setting Kemeng Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec8aca6c-1e8c-3fe9-81d7-d18876cc40cb@huaweicloud.com \
--to=shikemeng@huaweicloud.com \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).