From: Goldwyn Rodrigues <rgoldwyn@suse.de>
To: Markus Trippelsdorf <markus@trippelsdorf.de>,
Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
David Howells <dhowells@redhat.com>,
Lukas Czerner <lczerner@redhat.com>
Subject: Re: [PATCH] VFS: Handle lazytime in do_mount()
Date: Fri, 17 Nov 2017 06:09:21 -0600 [thread overview]
Message-ID: <ee6a6760-a0be-c066-2bcb-39ffacafa4c1@suse.de> (raw)
In-Reply-To: <20171011050131.GB13028@x4>
On 10/11/2017 12:01 AM, Markus Trippelsdorf wrote:
> Since commit e462ec50cb5fa ("VFS: Differentiate mount flags (MS_*) from
> internal superblock flags") the lazytime mount option doesn't get passed
> on anymore.
>
> Fix the issue by handling the option in do_mount().
>
> Reviewed-by: Lukas Czerner <lczerner@redhat.com>
> Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de>
Reviewed-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
> ---
> fs/namespace.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/namespace.c b/fs/namespace.c
> index 54059b142d6b..b633838b8f02 100644
> --- a/fs/namespace.c
> +++ b/fs/namespace.c
> @@ -2823,7 +2823,8 @@ long do_mount(const char *dev_name, const char __user *dir_name,
> SB_MANDLOCK |
> SB_DIRSYNC |
> SB_SILENT |
> - SB_POSIXACL);
> + SB_POSIXACL |
> + SB_LAZYTIME);
>
> if (flags & MS_REMOUNT)
> retval = do_remount(&path, flags, sb_flags, mnt_flags,
>
--
Goldwyn
next prev parent reply other threads:[~2017-11-17 12:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 5:01 [PATCH] VFS: Handle lazytime in do_mount() Markus Trippelsdorf
2017-11-17 12:09 ` Goldwyn Rodrigues [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-09-18 19:26 mounting with lazytime doesn't work on ext4 Markus Trippelsdorf
2017-09-19 8:35 ` Markus Trippelsdorf
2017-09-19 10:18 ` [PATCH] VFS: Handle lazytime in do_mount() Markus Trippelsdorf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee6a6760-a0be-c066-2bcb-39ffacafa4c1@suse.de \
--to=rgoldwyn@suse.de \
--cc=adilger.kernel@dilger.ca \
--cc=dhowells@redhat.com \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@trippelsdorf.de \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).