Re: Using tgid instead of pid in ext3_find_near()

Mulyadi Santosa
2008-04-29T00:57:06Z

Ehmmm....

On Tue, Apr 29, 2008 at 2:07 AM, Manish Katiyar <mkatiyar@gmail.com> wrote:
> Hi,
>
> In the function ext*_find_near() we are using pid to have the locality
> of the blocks for the files which have same functionality. Shouldn't
> we be using "current->tgid" here instead ??
>
> 410 static ext3_fsblk_t ext3_find_near(struct inode *inode, Indirect *ind)
> 411 {
> .........
> ........
> 433 colour = (current->pid % 16) *
> 434 (EXT3_BLOCKS_PER_GROUP(inode->i_sb) / 16);
> ........

Because each threads even on same thread group doesn't need to share
open file descriptors?

regards,

Mulyadi.