From: Ritesh Harjani <riteshh@linux.ibm.com>
To: harshad shirwadkar <harshadshirwadkar@gmail.com>
Cc: Andrea Righi <andrea.righi@canonical.com>,
"Theodore Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: properly check for dirty state in ext4_inode_datasync_dirty()
Date: Wed, 28 Oct 2020 10:03:01 +0530 [thread overview]
Message-ID: <f41af253-bd90-805d-a304-71f2f8f454f7@linux.ibm.com> (raw)
In-Reply-To: <CAD+ocbz0NpXYK9fCxpEYGz6fvWJ_SLw+rYQ2yo3UbKJbbEX8hg@mail.gmail.com>
On 10/28/20 9:18 AM, harshad shirwadkar wrote:
> Actually the simpler fix for this in case of fast commits is to check
> if the inode is on the fast commit list or not. Since we clear the
> fast commit list after every fast and / or full commit, it's always
> true that if the inode is not on the list, that means it isn't dirty.
> This will simplify the logic here and then we can probably get rid of
> i_fc_committed_subtid field altogether. I'll test this and send out a
> patch.
Yes, sounds like a better solution. Thanks!
-ritesh
next prev parent reply other threads:[~2020-10-29 2:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-24 14:01 [PATCH] ext4: properly check for dirty state in ext4_inode_datasync_dirty() Andrea Righi
2020-10-26 22:28 ` harshad shirwadkar
2020-10-28 3:27 ` Ritesh Harjani
2020-10-28 3:48 ` harshad shirwadkar
2020-10-28 4:33 ` Ritesh Harjani [this message]
2020-10-28 15:29 ` Theodore Y. Ts'o
2020-10-28 17:26 ` Ritesh Harjani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f41af253-bd90-805d-a304-71f2f8f454f7@linux.ibm.com \
--to=riteshh@linux.ibm.com \
--cc=adilger.kernel@dilger.ca \
--cc=andrea.righi@canonical.com \
--cc=harshadshirwadkar@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).