Re: [RFC, PATCH 4/6] jbd: refactor nested journal log recovery loop into separate functions

Duane Griffin
2008-03-08T18:40:31Z

On 08/03/2008, Christoph Hellwig <hch@infradead.org> wrote:
> On Thu, Mar 06, 2008 at 01:59:12AM +0000, Duane Griffin wrote:
> > +static int replay_data_block(
> > + journal_t *journal, struct buffer_head *obh, char *data,
> > + int flags, unsigned long blocknr)
>
> quite odd formatting, this should be more like:
>
> static int replay_data_block(journal_t *journal, struct buffer_head *obh,
> char *data, int flags, unsigned long blocknr)
>
> (same for the other new helpers)

OK, will change.

Thanks,
Duane.

--
"I never could learn to drink that blood and call it wine" - Bob Dylan