From: Jiayuan Chen <jiayuan.chen@linux.dev>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org,
Jiayuan Chen <jiayuan.chen@shopee.com>,
Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Ye Bin <yebin10@huawei.com>,
Ritesh Harjani <riteshh@linux.ibm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ext4: fix use-after-free in update_super_work when racing with umount
Date: Thu, 19 Mar 2026 19:17:04 +0800 [thread overview]
Message-ID: <f801417f-5010-4820-8eed-42f1e10f2076@linux.dev> (raw)
In-Reply-To: <h4afxbv3sivvopwqfnccd235wywla6bvwk6a5qp5yuwg5pnr2e@s7jlvfxjgxgq>
On 3/19/26 6:50 PM, Jan Kara wrote:
> The initialization of s_error_notify_mutex should happen early in
> ext4_fill_super() as ext4_notify_error_sysfs() can be called rather early
> before ext4_register_sysfs() is called.
>
> Also we should protect kobject_init_and_add() with s_error_notify_mutex to
> handle the case where ext4_notify_error_sysfs() is racing with
> ext4_register_sysfs().
>
> Honza
> -- Jan Kara <jack@suse.com> SUSE Labs, CR
Hi Honza,
Thanks for the review! The AI catches are reasonable — I'll move
mutex_init() earlier in ext4_fill_super() and protect kobject_init_and_add()
with the mutex.
Thanks,
Jiayuan
next prev parent reply other threads:[~2026-03-19 11:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 7:36 [PATCH v2] ext4: fix use-after-free in update_super_work when racing with umount Jiayuan Chen
2026-03-19 10:50 ` Jan Kara
2026-03-19 11:17 ` Jiayuan Chen [this message]
2026-03-20 10:27 ` [syzbot ci] " syzbot ci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f801417f-5010-4820-8eed-42f1e10f2076@linux.dev \
--to=jiayuan.chen@linux.dev \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=jiayuan.chen@shopee.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=riteshh@linux.ibm.com \
--cc=tytso@mit.edu \
--cc=yebin10@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox