From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5E90C56201 for ; Wed, 21 Oct 2020 21:17:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B9FC2419A for ; Wed, 21 Oct 2020 21:17:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="dxGEwJFI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2505983AbgJUVRG (ORCPT ); Wed, 21 Oct 2020 17:17:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2505979AbgJUVRG (ORCPT ); Wed, 21 Oct 2020 17:17:06 -0400 Received: from merlin.infradead.org (merlin.infradead.org [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B454BC0613CE; Wed, 21 Oct 2020 14:17:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=L9KnamqfyhOdaOnsHrZ3+u3zuYCeeODQD2KveoFX8B4=; b=dxGEwJFIkFhR4AGD6OIasdLsGm X7Zaf8U/UPlthCqRigt8VFsfISdBNgvkrkhOklbHb/6VuifWU6K9BSH7Hkm+IUAqlU/JbuPSzHoBQ PaEfpdRROppqf3ViL7v1UVvef4kT2LE75Dcqgvt1JKESCoJJm93AibfBs5GqJrGAjoA508w0w2myy ECuBgm9HUAX3dnxQJtY0U1NgeOlBIltWkqISdxf8iLWkBsupONq8ph2kxoTeUshHBnOQ4ABgf3tjx bxSkfOsjyoXWtFPhJLv78Vlz9JimQEYkILK+GHsn27XoLJRj4s3pwK/u9tDdgprEHJUNdVrrxqnXM w2ftX8Fg==; Received: from [2601:1c0:6280:3f0::507c] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kVLTi-0008Cd-8p; Wed, 21 Oct 2020 21:17:02 +0000 Subject: Re: [PATCH] ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it To: Brendan Higgins , Geert Uytterhoeven Cc: Theodore Ts'o , Andreas Dilger , Shuah Khan , Iurii Zaikin , Paolo Abeni , Matthieu Baerts , linux-ext4@vger.kernel.org, Linux Kernel Mailing List , David Gow References: <20201020073740.29081-1-geert@linux-m68k.org> From: Randy Dunlap Message-ID: Date: Wed, 21 Oct 2020 14:16:56 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On 10/21/20 2:15 PM, Brendan Higgins wrote: > On Tue, Oct 20, 2020 at 12:37 AM Geert Uytterhoeven > wrote: >> >> EXT4_KUNIT_TESTS selects EXT4_FS, thus enabling an optional feature the >> user may not want to enable. Fix this by making the test depend on >> EXT4_FS instead. >> >> Fixes: 1cbeab1b242d16fd ("ext4: add kunit test for decoding extended timestamps") >> Signed-off-by: Geert Uytterhoeven > > If I remember correctly, having EXT4_KUNIT_TESTS select EXT4_FS was > something that Ted specifically requested, but I don't have any strong > feelings on it either way. omg, please No. depends on is the right fix here. -- ~Randy