* [PATCH] ext4: BUG_ON could be triggered in ext4_mb_normalize_request()
@ 2010-04-07 13:51 jing zhang
0 siblings, 0 replies; only message in thread
From: jing zhang @ 2010-04-07 13:51 UTC (permalink / raw)
To: linux-ext4
Cc: Theodore Ts'o, Andreas Dilger, Dave Kleikamp,
Aneesh Kumar K. V
From: Jing Zhang <zj.barak@gmail.com>
Date: Wed Apr 7 21:34:48 2010
BUG_ON at [line: 2912] could be triggered,
if (pa->pa_deleted == 0 && pa->pa_free == 0)
as checked at [line: 3111] and [line: 3122].
It is bypassed by adding check for pa_free.
Cc: Theodore Ts'o <tytso@mit.edu>
Cc: Andreas Dilger <adilger@sun.com>
Cc: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
Cc: Aneesh Kumar K. V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: Jing Zhang <zj.barak@gmail.com>
---
--- linux-2.6.32/fs/ext4/mballoc.c 2009-12-03 11:51:22.000000000 +0800
+++ ext4_mm_leak/mballoc-16.c 2010-04-07 20:20:26.000000000 +0800
@@ -2901,7 +2901,7 @@ ext4_mb_normalize_request(struct ext4_al
if (pa->pa_deleted)
continue;
spin_lock(&pa->pa_lock);
- if (pa->pa_deleted) {
+ if (pa->pa_deleted || 0 == pa->pa_free) {
spin_unlock(&pa->pa_lock);
continue;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-04-07 13:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-07 13:51 [PATCH] ext4: BUG_ON could be triggered in ext4_mb_normalize_request() jing zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).