From: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
To: skoyama.kernel@gmail.com, linux-ext4@vger.kernel.org
Cc: Sohei Koyama <skoyama@ddn.com>
Subject: Re: [PATCH] ext4: fix missing brelse() in ext4_xattr_inode_dec_ref_all()
Date: Thu, 02 Apr 2026 06:34:36 +0530 [thread overview]
Message-ID: <jyuqmau3.ritesh.list@gmail.com> (raw)
In-Reply-To: <20260330174248.71268-1-skoyama@ddn.com>
skoyama.kernel@gmail.com writes:
> From: Sohei Koyama <skoyama@ddn.com>
>
> The commit c8e008b60492 ("ext4: ignore xattrs past end")
> introduced a refcount leak in when block_csum is false.
>
> ext4_xattr_inode_dec_ref_all() calls ext4_get_inode_loc() to
> get iloc.bh, but never releases it with brelse().
>
> Fixes: c8e008b60492 ("ext4: ignore xattrs past end")
Nice catch, indeed we need to decrement the refcount for bh there.
Since this patch made into stable releases, so I guess it's good to
Cc:stable too.
Feel free to add:
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
prev parent reply other threads:[~2026-04-02 1:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 17:42 [PATCH] ext4: fix missing brelse() in ext4_xattr_inode_dec_ref_all() skoyama.kernel
2026-03-30 19:08 ` Andreas Dilger
2026-04-02 1:04 ` Ritesh Harjani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jyuqmau3.ritesh.list@gmail.com \
--to=ritesh.list@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=skoyama.kernel@gmail.com \
--cc=skoyama@ddn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox